FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fs: throw fchownSync error from c++ by anonrig · Pull Request #51075 · nodejs/node · GitHub

/ node Public

fs: throw fchownSync error from c++ - #51075

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:throw-error-on-cpp-fchown
Dec 12, 2023
ConversationCommits (1)ChecksFiles changed
Merged

fs: throw fchownSync error from c++#51075
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:throw-error-on-cpp-fchown

Conversation

anonrig commented Dec 6, 2023

Copy link
Copy Markdown
Member

Ref: nodejs/performance#106

#49920 seems to be abandoned.

cc @nodejs/fs

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. typings labels Dec 6, 2023
anonrig mentioned this pull request Dec 6, 2023
Open
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2023

nodejs-github-bot commented Dec 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56139/

nodejs-github-bot commented Dec 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56145/

anonrig commented Dec 7, 2023

Copy link
Copy Markdown
Member Author

cc @nodejs/fs @nodejs/cpp-reviewers appreciate if you could leave a review.

CanadaHonk approved these changes Dec 7, 2023
View reviewed changes

CanadaHonk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tniessen commented Dec 7, 2023

Copy link
Copy Markdown
Member

I believe @H4ad suggested to re-run benchmarks for these changes in nodejs/performance#106.

H4ad commented Dec 7, 2023

Copy link
Copy Markdown
Member

@anonrig Can you update the benchmark of bench-chownSync.js to include this method? Just to see if those changes are still relevant compared to the new improvements made on errors.

nodejs-github-bot commented Dec 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56194/

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 12, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 12, 2023
nodejs-github-bot merged commit 3551dc0 into nodejs:main Dec 12, 2023

nodejs-github-bot commented Dec 12, 2023

Copy link
Copy Markdown
Collaborator

Landed in 3551dc0

anonrig commented Dec 12, 2023

Copy link
Copy Markdown
Member Author

@anonrig Can you update the benchmark of bench-chownSync.js to include this method? Just to see if those changes are still relevant compared to the new improvements made on errors.

I missed this comment. Sorry I just realized that I didn't comment on this.

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
fs: throw fchownSync error from c++
35e8f26 
PR-URL: #51075
Refs: nodejs/performance#106
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS mentioned this pull request Dec 15, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
fs: throw fchownSync error from c++
afd5d67 
PR-URL: #51075
Refs: nodejs/performance#106
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau mentioned this pull request Mar 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Qard Qard approved these changes
jasnell jasnell approved these changes
+1 more reviewer
CanadaHonk CanadaHonk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. typings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL