FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix broken env fuzzer by initializing process by AdamKorcz · Pull Request #51080 · nodejs/node · GitHub

/ node Public

test: fix broken env fuzzer by initializing process - #51080

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
AdamKorcz:fix-fuzz-build
May 12, 2024
ConversationCommits (1)ChecksFiles changed
Merged

test: fix broken env fuzzer by initializing process #51080
aduh95 merged 1 commit into
nodejs:mainfrom
AdamKorcz:fix-fuzz-build

Conversation

AdamKorcz commented Dec 6, 2023

Copy link
Copy Markdown
Contributor

Fixes a broken fuzzer.

It looks like the fuzzer is leaking memory, but it is so slow that it is hard to tell. Once the fuzzer starts running on OSS-Fuzz again, we should get good feedback. If it has a leak, then I plan to fix it over the next couple of weeks; If anyone can spot a possible leak without running it, it would be a great help.

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 6, 2023
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2023

nodejs-github-bot commented Dec 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56146/

AdamKorcz closed this Dec 7, 2023
AdamKorcz reopened this Dec 7, 2023

nodejs-github-bot commented Dec 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56211/

AdamKorcz changed the title test: fix broken fuzzer test: fix broken env fuzzer by initializing process Dec 11, 2023
AdamKorcz mentioned this pull request Dec 12, 2023
Closed
joyeecheung approved these changes Dec 15, 2023
View reviewed changes

joyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM though I do wonder why this is not using node::InitializeOncePerProcess() instead..

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2023

nodejs-github-bot commented Dec 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56321/

joyeecheung commented Dec 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

It looks like the fuzzer is leaking memory, but it is so slow that it is hard to tell.

Actually I just noticed that it seems the fuzzers aren't tearing down the platform etc. properly. See

node/test/cctest/node_test_fixture.cc

Lines 36 to 43 in b68fa59

void NodeTestEnvironment::TearDown() {
cppgc::ShutdownProcess();
v8::V8::Dispose();
v8::V8::DisposePlatform();
NodeZeroIsolateTestFixture::platform->Shutdown();
NodeZeroIsolateTestFixture::platform.reset(nullptr);
NodeZeroIsolateTestFixture::tracing_agent.reset(nullptr);
}
for an example

AdamKorcz commented Dec 15, 2023

Copy link
Copy Markdown
Contributor Author

It looks like the fuzzer is leaking memory, but it is so slow that it is hard to tell.

Actually I just noticed that it seems the fuzzers aren't tearing down the platform etc. properly. See

node/test/cctest/node_test_fixture.cc

Lines 36 to 43 in b68fa59

void NodeTestEnvironment::TearDown() {
cppgc::ShutdownProcess();
v8::V8::Dispose();
v8::V8::DisposePlatform();
NodeZeroIsolateTestFixture::platform->Shutdown();
NodeZeroIsolateTestFixture::platform.reset(nullptr);
NodeZeroIsolateTestFixture::tracing_agent.reset(nullptr);
}

for an example

Thank you for the feedback. I will test this and make a follow-up PR.

test: fix broken env fuzzer by initializing process
15e3604 
Signed-off-by: Adam Korczynski <adam@adalogics.com>
aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 11, 2024

nodejs-github-bot commented May 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59111/

nodejs-github-bot commented May 12, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59153/

aduh95 merged commit d9b61db into nodejs:main May 12, 2024

aduh95 commented May 12, 2024

Copy link
Copy Markdown
Contributor

Landed in d9b61db

targos pushed a commit that referenced this pull request May 12, 2024
test: fix broken env fuzzer by initializing process
4d50d51 
Signed-off-by: Adam Korczynski <adam@adalogics.com>
PR-URL: #51080
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos mentioned this pull request May 13, 2024
Merged
marco-ippolito mentioned this pull request Jun 17, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
test: fix broken env fuzzer by initializing process
cc74bf7 
Signed-off-by: Adam Korczynski <adam@adalogics.com>
PR-URL: #51080
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
test: fix broken env fuzzer by initializing process
8aaf8aa 
Signed-off-by: Adam Korczynski <adam@adalogics.com>
PR-URL: nodejs#51080
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
joyeecheung joyeecheung approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL