FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Updated packages.md and added --experimental-detect-module flag by shubherthi-mitra · Pull Request #51089 · nodejs/node · GitHub

/ node Public

Updated packages.md and added --experimental-detect-module flag - #51089

Merged
aduh95 merged 5 commits into
nodejs:mainfrom
shubherthi-mitra:patch-1
Dec 9, 2023
Merged

Updated packages.md and added --experimental-detect-module flag#51089
aduh95 merged 5 commits into
nodejs:mainfrom
shubherthi-mitra:patch-1

Conversation

shubherthi-mitra commented Dec 7, 2023
edited by aduh95
Loading

Copy link
Copy Markdown
Contributor

added --experimental-detect-module flag in the docs to resolve #51057

Fixes: #51057

added --experimental-detect-module flag in the docs.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 7, 2023

Copy link
Copy Markdown
Member

It feels wrong to duplicate what we have in cli.md, though it seems we’re doing the same for --input-type. Perhaps both sections should just be links to the parallel sections in cli.md, rather than repeating the content and gradually getting out of sync.

Copy link
Copy Markdown
Contributor Author

It feels wrong to duplicate what we have in cli.md, though it seems we’re doing the same for --input-type. Perhaps both sections should just be links to the parallel sections in cli.md, rather than repeating the content and gradually getting out of sync.

@GeoffreyBooth I understand. But I did this after I asked here #51057 to fix the issue mentioned there. I'm new to github. My apology if any trouble caused.

Copy link
Copy Markdown
Member

@shubherthi-mitra you didn’t do anything wrong, thank you for the contribution! My question was more for @nodejs/loaders, if we want to repeat the info here like you’ve done in this PR or if we’d rather do it differently, such as by just mentioning the flag’s existence and linking to its primary documentation.

Copy link
Copy Markdown
Member

just mentioning the flag’s existence and linking to its primary documentation

I think this (smaller surface area to update, less chance of divergence).

aduh95 commented Dec 8, 2023

Copy link
Copy Markdown
Contributor

I think what we want is to modify the paragraph added in https://github.com/nodejs/node/pull/50096/files#diff-71a7964a5c439435680952125e31e9dd4fca3a427982e6db86770fd0fbbfde63 to add a mention of the flag (and a link to cli.md).

Mentioned --experimental-detect-module flag and added its reference to cli.md

Copy link
Copy Markdown
Contributor Author

I think what we want is to modify the paragraph added in https://github.com/nodejs/node/pull/50096/files#diff-71a7964a5c439435680952125e31e9dd4fca3a427982e6db86770fd0fbbfde63 to add a mention of the flag (and a link to cli.md).

I did as you have said. Please check it.

Comment thread doc/api/packages.md Outdated
--experimental-detect-module flag and link to cli.md added.
Comment thread doc/api/packages.md Outdated
Mentioned --experimental-defect-module flag in doc and added ref link to cli.md
Comment thread doc/api/packages.md Outdated
Simplified the paragraph under the heading ###Determining module system, mentioning --experimental-detect-module flag and reference to cli.md

JakobJingleheimer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

aduh95 merged commit 37ba7a3 into nodejs:main Dec 9, 2023

aduh95 commented Dec 9, 2023

Copy link
Copy Markdown
Contributor

Landed in 37ba7a3, thanks for the contribution 🎉

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
PR-URL: #51089
Fixes: #51057
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS mentioned this pull request Dec 15, 2023
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51089
Fixes: #51057
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
richardlau mentioned this pull request Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node can't recognize static import of ES module when theres's not explicit marker

6 participants


Back | FazBrowse Home | New Git URL