FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: add fuzzer for native/js string conversion by AdamKorcz · Pull Request #51120 · nodejs/node · GitHub

/ node Public

test: add fuzzer for native/js string conversion - #51120

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
AdamKorcz:add-string-fuzzers
May 12, 2024
ConversationCommits (1)ChecksFiles changed
Merged

test: add fuzzer for native/js string conversion#51120
aduh95 merged 1 commit into
nodejs:mainfrom
AdamKorcz:add-string-fuzzers

Conversation

AdamKorcz commented Dec 11, 2023

Copy link
Copy Markdown
Contributor

Adds a fuzzer for the following APIs:

napi_create_string_utf8
napi_get_value_string_utf8
napi_create_string_latin1
napi_get_value_string_latin1

The PR also adds the fuzzer to Node's OSS-Fuzz build, so that OSS-Fuzz will run this fuzzer continuously.

nodejs-github-bot commented Dec 11, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Dec 11, 2023
AdamKorcz mentioned this pull request Dec 12, 2023
Closed
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2023
anonrig added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 15, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2023

nodejs-github-bot commented Dec 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56298/

tniessen added the test Issues and PRs related to the tests. label Dec 15, 2023
joyeecheung reviewed Dec 15, 2023
View reviewed changes

joyeecheung left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is not tearing down the platform etc. properly. One possibility is copying what v8's fuzzer does and run the teardown in the destructor of a global variable:

https://github.com/nodejs/node/blob/16e03e79688d51f95dfdbc90f5b8f56e3e995c6c/deps/v8/test/fuzzer/fuzzer-support.cc

joyeecheung reviewed Dec 15, 2023
View reviewed changes
Comment thread test/fuzzers/fuzz_strings.cc Outdated

joyeecheung Dec 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can this just use node::InitializeOncePerProcess() instead? Then there's no need to repeat the initialization routines below (and potentially missing some steps whenever there are internal updates), unless there's a reason that those have to be customized (from what I can tell, that's not necessary?)

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label May 10, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 10, 2024

nodejs-github-bot commented May 10, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59083/

nodejs-github-bot commented May 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59113/

nodejs-github-bot commented May 12, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59155/

test: add fuzzer for native/js string conversion
c8805b8 
Signed-off-by: Adam Korczynski <adam@adalogics.com>
PR-URL: nodejs#51120
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
aduh95 force-pushed the add-string-fuzzers branch from 919306c to c8805b8 Compare May 12, 2024 17:50

aduh95 commented May 12, 2024

Copy link
Copy Markdown
Contributor

Landed in c8805b8

aduh95 merged commit c8805b8 into nodejs:main May 12, 2024
targos pushed a commit that referenced this pull request May 12, 2024
test: add fuzzer for native/js string conversion
c676e52 
Signed-off-by: Adam Korczynski <adam@adalogics.com>
PR-URL: #51120
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
targos mentioned this pull request May 13, 2024
Merged
marco-ippolito mentioned this pull request Jun 17, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
test: add fuzzer for native/js string conversion
7dda156 
Signed-off-by: Adam Korczynski <adam@adalogics.com>
PR-URL: #51120
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
test: add fuzzer for native/js string conversion
8c5fe1c 
Signed-off-by: Adam Korczynski <adam@adalogics.com>
PR-URL: nodejs#51120
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

joyeecheung joyeecheung left review comments
anonrig anonrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL