FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: fix deadlock when cloning webstreams by tsctx · Pull Request #51131 · nodejs/node · GitHub

/ node Public

stream: fix deadlock when cloning webstreams - #51131

Closed
tsctx wants to merge 1 commit into
nodejs:mainfrom
tsctx:stream/using-structuredClone-for-webstream-still-terminates-process
ConversationCommits (1)ChecksFiles changed
Closed

stream: fix deadlock when cloning webstreams#51131
tsctx wants to merge 1 commit into
nodejs:mainfrom
tsctx:stream/using-structuredClone-for-webstream-still-terminates-process

Conversation

tsctx commented Dec 12, 2023

Copy link
Copy Markdown
Member

Fixes #44985.
Fixed a problem where the process would not terminate if structuredClone was used for webstream and body was not consumed.

nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Dec 12, 2023
lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2023

nodejs-github-bot commented Dec 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56283/

aduh95 reviewed Dec 17, 2023
View reviewed changes

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you amend the commit message so it matches our guidelines? using is not an imperative verb, I suggest something like stream: fix deadlock when cloning webstreams

node/doc/contributing/pull-requests.md

Lines 170 to 172 in 1149d6b

* be prefixed with the name of the changed [subsystem](#appendix-subsystems)
and start with an imperative verb. Check the output of `git log --oneline
files/you/changed` to find out what subsystems your changes touch.

Comment thread test/parallel/test-webstreams-using-structuredclone-exit-process.js Outdated
Comment thread test/parallel/test-webstreams-using-structuredclone-exit-process.js Outdated
Comment thread test/parallel/test-webstreams-using-structuredclone-exit-process.js Outdated
Comment thread test/parallel/test-webstreams-using-structuredclone-exit-process.js Outdated
Comment thread test/parallel/test-webstreams-using-structuredclone-exit-process.js Outdated
tsctx changed the title stream: using structuredClone for webstream still terminates process stream: fix deadlock when cloning webstreams Dec 17, 2023
H4ad added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 19, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2023

nodejs-github-bot commented Dec 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56394/

tsctx commented Dec 20, 2023

Copy link
Copy Markdown
Member Author

There seems to be a problem with FinalizationRegistry, so please wait for that to be resolved.

nodejs-github-bot commented Dec 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56407/

H4ad requested changes Dec 21, 2023
View reviewed changes

H4ad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@tsctx Can you elaborate? (just use request change to block merge)

tsctx commented Dec 21, 2023

Copy link
Copy Markdown
Member Author

@H4ad
#49344
#47748

jasnell requested changes Dec 22, 2023
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Appreciate the work on this but this isn't the correct fix. The issue is the fact that cloned ReadableStream and WritableStream instances use a MessageChannel under the covers to communicate. The MessagePorts for each need to be unref'd in order to allow the process to exit. I'll have an alternative PR opened shortly.

jasnell mentioned this pull request Dec 22, 2023
Merged
tsctx closed this Dec 22, 2023
tsctx deleted the stream/using-structuredClone-for-webstream-still-terminates-process branch December 22, 2023 04:41
H4ad mentioned this pull request Jan 16, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 left review comments
jasnell jasnell requested changes
H4ad H4ad requested changes
KhafraDev KhafraDev approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. web streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: using structuredClone with ReadableStream prevents process from exiting

7 participants

Back | FazBrowse Home | New Git URL