FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

watch: fix infinite loop when passing --watch=true flag by pulkit-30 · Pull Request #51160 · nodejs/node · GitHub

/ node Public

watch: fix infinite loop when passing --watch=true flag - #51160

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
pulkit-30:fix-watch
Dec 16, 2023
ConversationCommits (1)ChecksFiles changed
Merged

watch: fix infinite loop when passing --watch=true flag#51160
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
pulkit-30:fix-watch

Conversation

pulkit-30 commented Dec 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

fix: #51159

code:

console.log("hello world!");

run with cmd: ./node --watch=true index.mjs

before:

pulkitgupta@Pulkits-MacBook-Air node % ./node --watch=true index.mjs
(node:26067) ExperimentalWarning: Watch mode is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:26068) ExperimentalWarning: Watch mode is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:26069) ExperimentalWarning: Watch mode is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:26070) ExperimentalWarning: Watch mode is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:26071) ExperimentalWarning: Watch mode is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:26072) ExperimentalWarning: Watch mode is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:26073) ExperimentalWarning: Watch mode is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:26074) ExperimentalWarning: Watch mode is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:26075) ExperimentalWarning: Watch mode is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:26076) ExperimentalWarning: Watch mode is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
(node:26077) ExperimentalWarning: Watch mode is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
^C%

now:

pulkitgupta@Pulkits-MacBook-Air node % ./node --watch=true index.mjs
(node:88235) ExperimentalWarning: Watch mode is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Hello world
Completed running 'index.mjs'

Note: watch-mode will be activated with --watch=false flag as well

nodejs-github-bot commented Dec 14, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Dec 14, 2023
pulkit-30 changed the title test_runner: fix infinite loop when passing --watch=true flag fs_watch: fix infinite loop when passing --watch=true flag Dec 15, 2023
pulkit-30 marked this pull request as ready for review December 15, 2023 09:26
pulkit-30 changed the title fs_watch: fix infinite loop when passing --watch=true flag watch: fix infinite loop when passing --watch=true flag Dec 15, 2023
MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2023

nodejs-github-bot commented Dec 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56303/

debadree25 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 15, 2023

nodejs-github-bot commented Dec 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56318/

debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 16, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 16, 2023
nodejs-github-bot merged commit 154afbe into nodejs:main Dec 16, 2023

nodejs-github-bot commented Dec 16, 2023

Copy link
Copy Markdown
Collaborator

Landed in 154afbe

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
watch: fix infinite loop when passing --watch=true flag
3f4fd6e 
PR-URL: #51160
Fixes: #51159
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
RafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
watch: fix infinite loop when passing --watch=true flag
07da4e9 
PR-URL: #51160
Fixes: #51159
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
richardlau mentioned this pull request Mar 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

MoLow MoLow approved these changes
marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

watch: --watch=true flag runs infinite loop

5 participants

Back | FazBrowse Home | New Git URL