FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http: remove misleading warning by lpinca · Pull Request #51204 · nodejs/node · GitHub

/ node Public

http: remove misleading warning - #51204

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
lpinca:remove/warning
Dec 21, 2023
ConversationCommits (2)ChecksFiles changed
Merged

http: remove misleading warning#51204
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
lpinca:remove/warning

Conversation

lpinca commented Dec 18, 2023

Copy link
Copy Markdown
Member

There are cases where the 'clientError' event can be emitted multiple times, even if the socket is correctly destroyed.

Fixes: #51073

http: remove misleading warning
5c6976b 
There are cases where the `'clientError'` event can be emitted multiple
times, even if the socket is correctly destroyed.

Fixes: nodejs#51073

nodejs-github-bot commented Dec 18, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Dec 18, 2023
lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 18, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 18, 2023

nodejs-github-bot commented Dec 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56361/

mcollina approved these changes Dec 18, 2023
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

nodejs-github-bot commented Dec 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56368/

pimterry reviewed Dec 19, 2023
View reviewed changes

pimterry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

Nice work, thanks @lpinca! I can imagine other solutions to fix this, like batching client errors, but one way or another they'd end up changing more sensitive existing behaviour elsewhere, so just dropping the incorrect warning seems much simpler.

nodejs-github-bot commented Dec 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56384/

lpinca added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 19, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2023

nodejs-github-bot commented Dec 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56392/

ShogunPanda commented Dec 20, 2023

Copy link
Copy Markdown
Contributor

Sorry, I don't understand this. If we remove this, we will reopen #43548. Or am I missing anything?

lpinca commented Dec 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

If we remove this, we will reopen #43548.

No, the fix for #43548 is still there. We added the warning because we could not reproduce the issue in a legit way. We can now and the warning is misleading.

ShogunPanda commented Dec 20, 2023

Copy link
Copy Markdown
Contributor

Oh, I see. Makes sense now. Thanks!

nodejs-github-bot commented Dec 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56406/

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2023
nodejs-github-bot merged commit 30f8ef1 into nodejs:main Dec 21, 2023

nodejs-github-bot commented Dec 21, 2023

Copy link
Copy Markdown
Collaborator

Landed in 30f8ef1

lpinca deleted the remove/warning branch December 21, 2023 20:09
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
http: remove misleading warning
c7a1359 
There are cases where the `'clientError'` event can be emitted multiple
times, even if the socket is correctly destroyed.

Fixes: #51073
PR-URL: #51204
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
RafaelGSS mentioned this pull request Jan 2, 2024
Merged
marco-ippolito mentioned this pull request Jan 29, 2024
Closed
richardlau pushed a commit that referenced this pull request Mar 25, 2024
http: remove misleading warning
f7b53d0 
There are cases where the `'clientError'` event can be emitted multiple
times, even if the socket is correctly destroyed.

Fixes: #51073
PR-URL: #51204
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
richardlau mentioned this pull request Mar 25, 2024
Merged
si458 mentioned this pull request Jun 26, 2024
Open

rejetto commented Feb 20, 2025

Copy link
Copy Markdown

this is not present in latest node 18, right?
even tho it has been published after this merge.

rejetto mentioned this pull request Feb 20, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pimterry pimterry left review comments
mcollina mcollina approved these changes
ShogunPanda ShogunPanda approved these changes
+1 more reviewer
aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HTTP server can report clientError misuse warning even when socket is destroyed correctly

7 participants

Back | FazBrowse Home | New Git URL