FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: use tmpdir.refresh() in test-esm-loader-resolve-type.mjs by lpinca · Pull Request #51206 · nodejs/node · GitHub

/ node Public

test: use tmpdir.refresh() in test-esm-loader-resolve-type.mjs - #51206

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:refresh/tmpdir-2
Dec 20, 2023
Merged

test: use tmpdir.refresh() in test-esm-loader-resolve-type.mjs#51206
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:refresh/tmpdir-2

Conversation

lpinca commented Dec 18, 2023

Copy link
Copy Markdown
Member

Use tmpdir.refresh() in
test/es-module/test-esm-loader-resolve-type.mjs so that the temporary directory is removed when the test exits.

Use `tmpdir.refresh()` in
`test/es-module/test-esm-loader-resolve-type.mjs` so that the temporary
directory is removed when the test exits.
nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 18, 2023
lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 18, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 18, 2023

Copy link
Copy Markdown
Collaborator

H4ad added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 19, 2023
debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 20, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 20, 2023
nodejs-github-bot merged commit 4071548 into nodejs:main Dec 20, 2023

Copy link
Copy Markdown
Collaborator

Landed in 4071548

lpinca deleted the refresh/tmpdir-2 branch December 20, 2023 18:42
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
Use `tmpdir.refresh()` in
`test/es-module/test-esm-loader-resolve-type.mjs` so that the temporary
directory is removed when the test exits.

PR-URL: #51206
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
RafaelGSS mentioned this pull request Jan 2, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Use `tmpdir.refresh()` in
`test/es-module/test-esm-loader-resolve-type.mjs` so that the temporary
directory is removed when the test exits.

PR-URL: #51206
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
richardlau mentioned this pull request Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL