FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: skip test-watch-mode-inspect on arm by mhdawson · Pull Request #51210 · nodejs/node · GitHub

/ node Public

test: skip test-watch-mode-inspect on arm - #51210

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mhdawson:exclude-test-watch-mode-inspect
Dec 22, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: skip test-watch-mode-inspect on arm#51210
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mhdawson:exclude-test-watch-mode-inspect

Conversation

mhdawson commented Dec 18, 2023

Copy link
Copy Markdown
Member

Refs: #49933

  • SKIP instead of mark FLAKY as tests seems to fail builds through left over processes

This seems to fail in almost every CI run look at.

test: skip test-watch-mode-inspect on arm
64f8f28 
Refs: nodejs#49933

- SKIP instead of mark FLAKY as tests seems to fail
  builds through left over processe

Signed-off-by: Michael Dawson <midawson@redhat.com>
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 18, 2023
mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 20, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 20, 2023

nodejs-github-bot commented Dec 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56410/

jasnell added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. and removed needs-ci PRs that need a full CI run. labels Dec 22, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2023
nodejs-github-bot merged commit 4f3261f into nodejs:main Dec 22, 2023

nodejs-github-bot commented Dec 22, 2023

Copy link
Copy Markdown
Collaborator

Landed in 4f3261f

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
test: skip test-watch-mode-inspect on arm
3db376f 
Refs: #49933

- SKIP instead of mark FLAKY as tests seems to fail
  builds through left over processe

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #51210
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
test: skip test-watch-mode-inspect on arm
6e62e64 
Refs: #49933

- SKIP instead of mark FLAKY as tests seems to fail
  builds through left over processe

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #51210
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau mentioned this pull request Mar 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL