Optimize Memory Usage by Hoisting Function in For Loop 馃捊 - #51242
Merged
aduh95 merged 4 commits intoDec 23, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aduh95
approved these changes
Dec 20, 2023
Comment thread
lib/internal/per_context/primordials.js
Outdated
Comment thread
lib/internal/per_context/primordials.js
Outdated
Fix variable naming Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Fix variable naming Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
Dec 20, 2023
anonrig
approved these changes
Dec 21, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aymen94
approved these changes
Dec 21, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 2, 2024
PR-URL: #51242 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51242 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this pull request introduces a very minor improvement in memory usage by hoisting the function outside the for loop. This adjustment offers benefits such as reducing the overhead of redefining the function in each iteration, resulting in a more optimized and efficient code execution.
Extremely sorry, if I made any mistakes :)