FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: fix use of `--frozen-intrinsics` with `--jitless` by aduh95 · Pull Request #51248 · nodejs/node · GitHub

/ node Public

lib: fix use of --frozen-intrinsics with --jitless - #51248

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:frozen-intrinsics-jitless
Dec 23, 2023
ConversationCommits (2)ChecksFiles changed
Merged

lib: fix use of --frozen-intrinsics with --jitless#51248
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:frozen-intrinsics-jitless

Conversation

aduh95 commented Dec 21, 2023

Copy link
Copy Markdown
Contributor

Fixes: #51232

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 21, 2023
targos reviewed Dec 21, 2023
View reviewed changes
Comment thread lib/internal/freeze_intrinsics.js Outdated
Update lib/internal/freeze_intrinsics.js
a7d624d 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 21, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2023

nodejs-github-bot commented Dec 21, 2023 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56440/ 💛

H4ad added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 21, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 23, 2023
nodejs-github-bot merged commit 825163c into nodejs:main Dec 23, 2023

nodejs-github-bot commented Dec 23, 2023

Copy link
Copy Markdown
Collaborator

Landed in 825163c

aduh95 deleted the frozen-intrinsics-jitless branch December 23, 2023 23:34
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
lib: fix use of --frozen-intrinsics with --jitless
6241429 
PR-URL: #51248
Fixes: #51232
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
lib: fix use of --frozen-intrinsics with --jitless
562947e 
PR-URL: #51248
Fixes: #51232
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau mentioned this pull request Mar 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
richardlau richardlau approved these changes
H4ad H4ad approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--jitless and --frozen-intrinsics options can not be combined

7 participants

Back | FazBrowse Home | New Git URL