FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: eliminate duplicate code in histogram.cc by jasnell · Pull Request #51263 · nodejs/node · GitHub

/ node Public

src: eliminate duplicate code in histogram.cc - #51263

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:histogram-simplification
Dec 25, 2023
ConversationCommits (1)ChecksFiles changed
Merged

src: eliminate duplicate code in histogram.cc#51263
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:histogram-simplification

Conversation

jasnell commented Dec 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Could likely benefit from some fast-api implementations as well, but that can be done separately.

jasnell requested a review from anonrig December 23, 2023 02:48
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Dec 23, 2023
jasnell marked this pull request as draft December 23, 2023 02:49
jasnell force-pushed the histogram-simplification branch from 050fa45 to 57fcfd2 Compare December 23, 2023 03:11
jasnell marked this pull request as ready for review December 23, 2023 03:11
jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2023
jasnell requested a review from mcollina December 23, 2023 03:13
jasnell force-pushed the histogram-simplification branch from 57fcfd2 to 5fbcc74 Compare December 23, 2023 03:15
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2023

nodejs-github-bot commented Dec 23, 2023 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56472/ 💛

jasnell added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 23, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 25, 2023
nodejs-github-bot merged commit a3a4eff into nodejs:main Dec 25, 2023

nodejs-github-bot commented Dec 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in a3a4eff

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
src: eliminate duplicate code in histogram.cc
df31c81 
PR-URL: #51263
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
RafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
src: eliminate duplicate code in histogram.cc
4ffdd37 
PR-URL: #51263
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
richardlau mentioned this pull request Mar 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig approved these changes
marco-ippolito marco-ippolito approved these changes
mcollina Awaiting requested review from mcollina

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL