FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: do not treat all paths ending with node_modules as such by targos · Pull Request #51269 · nodejs/node · GitHub

/ node Public

src: do not treat all paths ending with node_modules as such - #51269

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:fix-51245
Dec 25, 2023
ConversationCommits (1)ChecksFiles changed
Merged

src: do not treat all paths ending with node_modules as such#51269
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:fix-51245

Conversation

targos commented Dec 23, 2023

Copy link
Copy Markdown
Member

Fixes: #51245

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Dec 23, 2023
aduh95 approved these changes Dec 23, 2023
View reviewed changes

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Is / going to work on Windows though?

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 23, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2023

targos commented Dec 23, 2023

Copy link
Copy Markdown
Member Author

I suppose, yes. It's compared with a parsed URL.

nodejs-github-bot commented Dec 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56475/

nodejs-github-bot commented Dec 23, 2023 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56479/ 💛

anonrig approved these changes Dec 23, 2023
View reviewed changes

anonrig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice catch. Thank you for fixing this!

jasnell added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Dec 23, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 25, 2023
nodejs-github-bot merged commit c64e603 into nodejs:main Dec 25, 2023

nodejs-github-bot commented Dec 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in c64e603

ljharb commented Dec 25, 2023

Copy link
Copy Markdown
Member

cc @nodejs/loaders

targos deleted the fix-51245 branch December 25, 2023 20:02
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
src: do not treat all paths ending with node_modules as such
864ecb0 
Fixes: #51245
PR-URL: #51269
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
RafaelGSS mentioned this pull request Jan 2, 2024
Merged
joyeecheung mentioned this pull request Jan 23, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
anonrig anonrig approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ESM loader cannot detect module system properly in folder whose name ends with node_modules

8 participants

Back | FazBrowse Home | New Git URL