src: add fast api for Histogram - #51296
Merged
nodejs-github-bot merged 1 commit intoDec 29, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
anonrig
approved these changes
Dec 27, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
H4ad
approved these changes
Dec 27, 2023
H4ad
reviewed
Dec 27, 2023
Comment thread
benchmark/perf_hooks/histogram-record.js
Comment on lines
+18
to
+25
| histogram.max; | ||
| histogram.mean; | ||
| /* eslint-enable no-unused-expressions */ | ||
| } | ||
| bench.end(n); | ||
|
|
||
| // Avoid V8 deadcode (elimination) | ||
| assert.ok(histogram); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
In this case, I think you should have two variables to store the max/mean and then assert those variables to avoid deadcode elimination.
Sorry, something went wrong.
VoltrexKeyva
approved these changes
Dec 28, 2023
benjamingr
approved these changes
Dec 29, 2023
JungMinu
approved these changes
Dec 29, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 2, 2024
PR-URL: #51296 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51296 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.