FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: clarify dgram socket.send() multi-buffer support by mcollina · Pull Request #5130 · nodejs/node · GitHub

/ node Public

doc: clarify dgram socket.send() multi-buffer support - #5130

Closed
mcollina wants to merge 1 commit into
nodejs:masterfrom
mcollina:new-dgram-docs
ConversationCommits (1)ChecksFiles changed
Closed

doc: clarify dgram socket.send() multi-buffer support#5130
mcollina wants to merge 1 commit into
nodejs:masterfrom
mcollina:new-dgram-docs

Conversation

mcollina commented Feb 7, 2016

Copy link
Copy Markdown
Member

Fixes: #5124

@Trott @eljefedelrodeodeljefe @silverwind @nodejs/documentation Let me know if I need to change this more.

mcollina mentioned this pull request Feb 7, 2016
Closed

eljefedelrodeodeljefe commented Feb 7, 2016

Copy link
Copy Markdown
Contributor

LGTM. Good step in docs. Since tbh I was just using Buffers, not knowing any better :) Thanks.

Trott reviewed Feb 7, 2016
View reviewed changes
Comment thread doc/api/dgram.markdown Outdated

Trott Feb 7, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

the message the message -> the message

Trott commented Feb 7, 2016

Copy link
Copy Markdown
Member

One small typographical fix but LGTM otherwise.

r-52 added dgram Issues and PRs related to the dgram subsystem / UDP. doc Issues and PRs related to the documentations. lts-watch-v4.x labels Feb 7, 2016

jasnell commented Feb 7, 2016

Copy link
Copy Markdown
Member

LGTM
@mcollina ... this is related to your recently landed semver-minor adding the multiple buffer support right?

mcollina commented Feb 7, 2016

Copy link
Copy Markdown
Member Author

@jasnell yes.

Should I flag it anyhow in the commit message?

Anyway, I've updated the typo. Any other fix?

mcollina added semver-minor PRs that contain new features and should be released in the next minor version. and removed lts-watch-v4.x labels Feb 7, 2016

mcollina commented Feb 7, 2016

Copy link
Copy Markdown
Member Author

I've removed the LTS flag and added the semver-minor label.

doc: clarify dgram socket.send() multi-buffer support
f8a7cff 
Fixes: nodejs#5124
See: nodejs#4374
PR-URL: nodejs#5130
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Feb 7, 2016

Copy link
Copy Markdown
Member

This actual doc change does not need to be labeled semver-minor, we just need to make sure it doesn't land in v4

jasnell added dont-land-on-v4.x and removed semver-minor PRs that contain new features and should be released in the next minor version. labels Feb 7, 2016
mcollina added a commit that referenced this pull request Feb 8, 2016
doc: clarify dgram socket.send() multi-buffer support
76bc4c7 
Fixes: #5124
See: #4374
PR-URL: #5130
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

mcollina commented Feb 8, 2016

Copy link
Copy Markdown
Member Author

Landed as 76bc4c7.

mcollina closed this Feb 8, 2016
mcollina deleted the new-dgram-docs branch February 8, 2016 16:17
rvagg pushed a commit that referenced this pull request Feb 9, 2016
doc: clarify dgram socket.send() multi-buffer support
21b0b66 
Fixes: #5124
See: #4374
PR-URL: #5130
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 9, 2016
doc: clarify dgram socket.send() multi-buffer support
9f7aa6f 
Fixes: #5124
See: #4374
PR-URL: #5130
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
doc: clarify dgram socket.send() multi-buffer support
c88425b 
Fixes: nodejs#5124
See: nodejs#4374
PR-URL: nodejs#5130
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Apr 28, 2023
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dgram Issues and PRs related to the dgram subsystem / UDP. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL