quic: various additional cleanups, fixes in Endpoint - #51310
Closed
jasnell wants to merge 8 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
jasnell
force-pushed
the
quic-part-10
branch
from
d65779e to
1ae7f4b
Compare
December 29, 2023 15:52
jasnell
force-pushed
the
quic-part-10
branch
from
1346705 to
78765b9
Compare
December 29, 2023 17:57
anonrig
approved these changes
Dec 29, 2023
Comment thread
src/quic/tlscontext.h
Outdated
jasnell
force-pushed
the
quic-part-10
branch
4 times, most recently
from
10c3f63 to
dee88f8
Compare
December 29, 2023 22:10
jasnell
force-pushed
the
quic-part-10
branch
from
dee88f8 to
b0f1863
Compare
December 29, 2023 23:21
This comment was marked as outdated.
jasnell
force-pushed
the
quic-part-10
branch
from
f92586c to
f25e30b
Compare
December 29, 2023 23:34
This comment was marked as outdated.
jasnell
force-pushed
the
quic-part-10
branch
from
f25e30b to
2f9b603
Compare
December 29, 2023 23:46
This comment was marked as outdated.
jasnell
force-pushed
the
quic-part-10
branch
from
2f9b603 to
84dbe6a
Compare
December 29, 2023 23:48
This comment was marked as outdated.
This comment was marked as outdated.
Qard
reviewed
Dec 30, 2023
Qard
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Did a quick skim and left some comments. Will have to find time for a more in-depth review another time.
Sorry, something went wrong.
jasnell
force-pushed
the
quic-part-10
branch
from
ec493df to
615c63e
Compare
December 30, 2023 01:22
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
quic-part-10
branch
from
8f68912 to
6d0b4c7
Compare
December 30, 2023 18:35
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
added a commit
that referenced
this pull request
Jan 6, 2024
PR-URL: #51310 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Jan 12, 2024
PR-URL: nodejs#51310 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Medhansh404
pushed a commit
to Medhansh404/node
that referenced
this pull request
Jan 19, 2024
PR-URL: nodejs#51310 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
targos
pushed a commit
that referenced
this pull request
Feb 15, 2024
PR-URL: #51310 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More incremental implementation of quic/http3
Adds debug logging details, starts to add the http3 internal impl