fs,test: add URL to string to fs.watch - #51346
Merged
nodejs-github-bot merged 1 commit intoJan 5, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
RafaelGSS
force-pushed
the
validate-params-fs-watch
branch
from
0161109 to
c81d891
Compare
January 3, 2024 00:53
anonrig
approved these changes
Jan 3, 2024
MoLow
approved these changes
Jan 3, 2024
aduh95
reviewed
Jan 3, 2024
Comment thread
test/fixtures/permission/fs-read.js
| })); | ||
| assert.throws(() => { | ||
| fs.watch(blockedFileURL, () => {}); | ||
| }, common.expectsError({ |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
FWIW the expectsError is unnecessary
Suggested change
| }, common.expectsError({ | |
| }, { |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Jan 3, 2024
benjamingr
approved these changes
Jan 3, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
UlisesGascon
approved these changes
Jan 4, 2024
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Jan 12, 2024
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: nodejs#51346 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Medhansh404
pushed a commit
to Medhansh404/node
that referenced
this pull request
Jan 19, 2024
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: nodejs#51346 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 15, 2024
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #51346 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #51346 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if the URL is expected to be supported through fs.watch.
@nodejs/fs