FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: add URL tests to fs-write by RafaelGSS · Pull Request #51352 · nodejs/node · GitHub

/ node Public

test: add URL tests to fs-write - #51352

Merged
aduh95 merged 4 commits into
nodejs:mainfrom
RafaelGSS:add-url-fs-write-test
Jan 12, 2024
ConversationCommits (4)ChecksFiles changed
Merged

test: add URL tests to fs-write#51352
aduh95 merged 4 commits into
nodejs:mainfrom
RafaelGSS:add-url-fs-write-test

Conversation

RafaelGSS commented Jan 3, 2024

Copy link
Copy Markdown
Member

Following up #51213

RafaelGSS added the permission Issues and PRs related to the Permission Model label Jan 3, 2024
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 3, 2024
RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2024

nodejs-github-bot commented Jan 4, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56663/

aduh95 reviewed Jan 4, 2024
View reviewed changes
Comment thread test/fixtures/permission/fs-write.js Outdated
aduh95 reviewed Jan 4, 2024
View reviewed changes
Comment thread test/fixtures/permission/fs-write.js Outdated
RafaelGSS added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 4, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2024

nodejs-github-bot commented Jan 4, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56670/

nodejs-github-bot commented Jan 5, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56687/

RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 5, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 5, 2024

nodejs-github-bot commented Jan 5, 2024

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/51352
✔  Done loading data for nodejs/node/pull/51352
----------------------------------- PR info ------------------------------------
Title      test: add URL tests to fs-write (#51352)
Author     Rafael Gonzaga  (@RafaelGSS)
Branch     RafaelGSS:add-url-fs-write-test -> nodejs:main
Labels     test, needs-ci, commit-queue-squash, permission
Commits    2
 - test: add URL tests to fs-write
 - fixup! use pathToFileURL
Committers 2
 - RafaelGSS 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/51352
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51352
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - fixup! use pathToFileURL
   ℹ  This PR was created on Wed, 03 Jan 2024 18:30:27 GMT
   ✔  Approvals: 1
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/51352#pullrequestreview-1803386495
   ✘  This PR needs to wait 115 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-01-05T16:11:13Z: https://ci.nodejs.org/job/node-test-pull-request/56687/
- Querying data for job/node-test-pull-request/56687/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/7427405096

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jan 5, 2024
aduh95 reviewed Jan 7, 2024
View reviewed changes
Comment thread test/fixtures/permission/fs-write.js Outdated
Comment thread test/fixtures/permission/fs-write.js Outdated
Comment thread test/fixtures/permission/fs-write.js Outdated

RafaelGSS commented Jan 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

@aduh95 the common.expectsError is expected for two reasons:

RafaelGSS and others added 2 commits January 8, 2024 11:05
test: add URL tests to fs-write
837acd3
fixup! use pathToFileURL
451918d 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS force-pushed the add-url-fs-write-test branch from 9f2a02a to 451918d Compare January 8, 2024 14:05
RafaelGSS added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 8, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2024

nodejs-github-bot commented Jan 8, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56713/

aduh95 commented Jan 8, 2024

Copy link
Copy Markdown
Contributor
  • The entire file use this approach, I don't want to create another pattern (specifically on this file)

I think that's no longer true, no?

RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 11, 2024
RafaelGSS added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 11, 2024
aduh95 removed author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 11, 2024

This comment was marked as resolved.

Sign in to view

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 11, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 11, 2024

nodejs-github-bot commented Jan 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56746/

This comment was marked as resolved.

Sign in to view
RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 11, 2024
aduh95 removed author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 11, 2024
RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 11, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 11, 2024

nodejs-github-bot commented Jan 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56748/

nodejs-github-bot commented Jan 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56752/

nodejs-github-bot commented Jan 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56754/

nodejs-github-bot commented Jan 12, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56758/

aduh95 merged commit cf68d00 into nodejs:main Jan 12, 2024

aduh95 commented Jan 12, 2024

Copy link
Copy Markdown
Contributor

Landed in cf68d00

marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
test: add URL tests to fs-write
ad54787 
PR-URL: nodejs#51352
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
test: add URL tests to fs-write
9294bbf 
PR-URL: nodejs#51352
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
targos pushed a commit that referenced this pull request Feb 15, 2024
test: add URL tests to fs-write
7420a7d 
PR-URL: #51352
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
test: add URL tests to fs-write
292d017 
PR-URL: #51352
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
richardlau mentioned this pull request Mar 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 left review comments
anonrig anonrig approved these changes
LiviaMedeiros LiviaMedeiros approved these changes

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL