FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: remove openssl 1 update workflow by marco-ippolito · Pull Request #51378 · nodejs/node · GitHub

/ node Public

tools: remove openssl 1 update workflow - #51378

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:remove-openssl-1-update
Jan 7, 2024
Merged

tools: remove openssl 1 update workflow#51378
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:remove-openssl-1-update

Conversation

Copy link
Copy Markdown
Member

Remove update workflow for openssl v1 since it's no longer in our releases.
Fixes: nodejs/security-wg#1182

nodejs-github-bot commented Jan 5, 2024
edited by marco-ippolito
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 5, 2024
marco-ippolito force-pushed the remove-openssl-1-update branch from 739f78d to 8f2e721 Compare January 5, 2024 09:04
marco-ippolito added tools Issues and PRs related to the tools directory. openssl Issues and PRs related to the OpenSSL dependency. labels Jan 5, 2024
marco-ippolito changed the title Remove openssl 1 update tools: remove openssl 1 update Jan 5, 2024
marco-ippolito changed the title tools: remove openssl 1 update tools: remove openssl 1 update workflow Jan 5, 2024
marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2024

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

marco-ippolito added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 5, 2024

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 5, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 7, 2024
nodejs-github-bot merged commit 5d412a7 into nodejs:main Jan 7, 2024

Copy link
Copy Markdown
Collaborator

Landed in 5d412a7

marco-ippolito added a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
PR-URL: nodejs#51378
Fixes: nodejs/security-wg#1182
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
PR-URL: nodejs#51378
Fixes: nodejs/security-wg#1182
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Feb 15, 2024
PR-URL: #51378
Fixes: nodejs/security-wg#1182
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
marco-ippolito mentioned this pull request Mar 1, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51378
Fixes: nodejs/security-wg#1182
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
richardlau mentioned this pull request Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop openssl-v1-update

8 participants


Back | FazBrowse Home | New Git URL