test_runner: do not invoke after hook when test is empty - #51389
Merged
nodejs-github-bot merged 1 commit intoJan 8, 2024
Merged
test_runner: do not invoke after hook when test is empty#51389nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
lpinca
approved these changes
Jan 6, 2024
Comment thread
test/parallel/test-runner-skip-after-hook.js
Comment on lines
+6
to
+10
| test('test', async (t) => { | ||
| t.after(common.mustNotCall(() => { | ||
| t.fail('should not run'); | ||
| })); | ||
| }); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
| test('test', async (t) => { | |
| t.after(common.mustNotCall(() => { | |
| t.fail('should not run'); | |
| })); | |
| }); | |
| test('test', (t) => { | |
| t.after(common.mustNotCall()); | |
| }); |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
atlowChemi
approved these changes
Jan 7, 2024
marco-ippolito
added a commit
to marco-ippolito/node
that referenced
this pull request
Jan 12, 2024
PR-URL: nodejs#51389 Fixes: nodejs#51371 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Medhansh404
pushed a commit
to Medhansh404/node
that referenced
this pull request
Jan 19, 2024
PR-URL: nodejs#51389 Fixes: nodejs#51371 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #51371
(recreated because apparently if you force push on a closed PR it cannot be reopened)