build, tools: copy release assets to staging R2 bucket once built - #51394
Merged
nodejs-github-bot merged 1 commit intoMay 6, 2024
Merged
build, tools: copy release assets to staging R2 bucket once built#51394nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
4 tasks
targos
reviewed
Jan 7, 2024
Comment thread
Makefile
Outdated
flakey5
force-pushed
the
flakey5/nodejs/build/3602
branch
from
5bcb9ce to
d716fb0
Compare
January 8, 2024 00:31
targos
reviewed
Jan 8, 2024
Comment thread
Makefile
Outdated
targos
reviewed
Jan 8, 2024
Comment thread
Makefile
Outdated
targos
reviewed
Jan 8, 2024
Comment thread
Makefile
Outdated
targos
reviewed
Jan 8, 2024
Comment thread
Makefile
Outdated
targos
reviewed
Jan 8, 2024
Comment thread
vcbuild.bat
Outdated
flakey5
force-pushed
the
flakey5/nodejs/build/3602
branch
from
7a883e3 to
2da0546
Compare
January 10, 2024 21:34
targos
reviewed
Jan 11, 2024
Comment thread
vcbuild.bat
Outdated
flakey5
force-pushed
the
flakey5/nodejs/build/3602
branch
from
2da0546 to
9a7c146
Compare
January 17, 2024 20:35
targos
reviewed
Jan 18, 2024
Comment thread
tools/release.sh
Outdated
targos
reviewed
Jan 18, 2024
Comment thread
vcbuild.bat
Outdated
flakey5
force-pushed
the
flakey5/nodejs/build/3602
branch
2 times, most recently
from
85f98db to
87d2b3c
Compare
January 19, 2024 20:42
Copy link
Copy Markdown
Member
|
I did a test release build (https://ci-release.nodejs.org/job/iojs+release/9917/ for those who have access), but it failed to upload: 09:07:10 ssh node-www "aws s3 cp nodejs/custom/v22.0.0-test2024012187d2b3c18f/node-v22.0.0-test2024012187d2b3c18f-linux-x64.tar.gz s3://dist-staging/nodejs/custom/v22.0.0-test2024012187d2b3c18f/node-v22.0.0-test2024012187d2b3c18f-linux-x64.tar.gz --endpoint=https://07be8d2fbc940503ca1be344714cb0d1.r2.cloudflarestorage.com/" --profile=nodejs-r2-dist-bucket 09:07:12 09:07:12 The config profile (nodejs-r2-dist-bucket) could not be found 09:07:12 make: *** [Makefile:1291: binary-upload] Error 255 |
Sorry, something went wrong.
flakey5
force-pushed
the
flakey5/nodejs/build/3602
branch
from
87d2b3c to
a1b7767
Compare
January 22, 2024 21:40
Copy link
Copy Markdown
Member
Author
Should be the correct profile now (or at least this is the profile used here https://github.com/nodejs/build/blob/a721695e2b652bee056502e5c7da3ec03d1ca150/ansible/www-standalone/tools/promote/settings#L41) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
It looks much better:
There are a few failures, but I'll report them all when the job is finished. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
On Windows (all three builds): upload: nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-arm64.msi to s3://dist-staging/nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-arm64.msi 09:47:52 touch: cannot touch 's3://dist-staging/nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-win-arm64.zip.done': No such file or directory upload: nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-x64.msi to s3://dist-staging/nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-x64.msi 09:17:15 touch: cannot touch 's3://dist-staging/nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-win-x64.zip.done': No such file or directory upload: nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-x86.msi to s3://dist-staging/nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-x86.msi 09:19:02 touch: cannot touch 's3://dist-staging/nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-win-x86.zip.done': No such file or directory On macOS (osx11-release-pkg)09:33:01 scp -p node-v22.0.0-test20240123a1b77670ae.pkg node-www:nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae.pkg 09:33:06 ssh node-www "aws s3 cp nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae.pkg s3://dist-staging/nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae.pkg --endpoint=https://07be8d2fbc940503ca1be344714cb0d1.r2.cloudflarestorage.com/" --profile=worker" 09:33:06 /bin/sh: -c: line 0: unexpected EOF while looking for matching `"' 09:33:06 /bin/sh: -c: line 1: syntax error: unexpected end of file 09:33:06 make: *** [pkg-upload] Error 2 |
Sorry, something went wrong.
targos
reviewed
Jan 24, 2024
Comment thread
vcbuild.bat
Outdated
Copy link
Copy Markdown
Member
|
please review each new line in the Makefile. The double quotes are not placed correctly. |
Sorry, something went wrong.
flakey5
force-pushed
the
flakey5/nodejs/build/3602
branch
from
a1b7767 to
4d453df
Compare
January 24, 2024 20:21
targos
reviewed
Jan 26, 2024
Comment thread
Makefile
Outdated
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@flakey5 Can you please rebase on the latest main? It seems that the CI wrongly sets the major version as 22 instead of 23. |
Sorry, something went wrong.
flakey5
force-pushed
the
flakey5/nodejs/build/3602
branch
from
7121813 to
33c6584
Compare
May 5, 2024 22:29
Copy link
Copy Markdown
Member
Author
|
Done |
Sorry, something went wrong.
Co-authored-by: Michaël Zasso <targos@protonmail.com>
flakey5
force-pushed
the
flakey5/nodejs/build/3602
branch
from
33c6584 to
2ee2b5f
Compare
May 5, 2024 23:13
targos
approved these changes
May 6, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
flakey5
added a commit
to flakey5/nodejs-build
that referenced
this pull request
May 6, 2024
Note: nodejs/node#51394 should land before this does Reference nodejs#3602
targos
added a commit
that referenced
this pull request
May 8, 2024
Co-authored-by: Michaël Zasso <targos@protonmail.com> PR-URL: #51394 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
Co-authored-by: Michaël Zasso <targos@protonmail.com> PR-URL: #51394 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
Co-authored-by: Michaël Zasso <targos@protonmail.com> PR-URL: nodejs#51394 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau
pushed a commit
that referenced
this pull request
Nov 22, 2024
Co-authored-by: Michaël Zasso <targos@protonmail.com> PR-URL: #51394 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Feb 18, 2025
Co-authored-by: Michaël Zasso <targos@protonmail.com> PR-URL: nodejs#51394 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @MoLow @targos