benchmark: update iterations of benchmark/async_hooks/async-local- - #51420
Merged
nodejs-github-bot merged 1 commit intoMar 4, 2024
Conversation
Copy link
Copy Markdown
Author
|
benchmark@benchmark-S2600WFT: v16.20.2/bin/node benchmark/async_hooks/async-local-storage-getstore-nested-resources.js async_hooks/async-local-storage-getstore-nested-resources.js n=10000 resourceCount=10: 21,332,514.164789405 async_hooks/async-local-storage-getstore-nested-resources.js n=10000 resourceCount=100: 20,428,967.458697733 async_hooks/async-local-storage-getstore-nested-resources.js n=10000 resourceCount=1000: 19,337,123.4095216 benchmark@benchmark-S2600WFT: v20.10.0/bin/node benchmark/async_hooks/async-local-storage-getstore-nested-resources.js async_hooks/async-local-storage-getstore-nested-resources.js n=10000 resourceCount=10: 13,379,304.62402147 async_hooks/async-local-storage-getstore-nested-resources.js n=10000 resourceCount=100: 13,310,421.660847794 async_hooks/async-local-storage-getstore-nested-resources.js n=10000 resourceCount=1000: 13,387,149.67502694 compared with node16, node21 performance downgraded by about 40%. Root cause is repetition is too small and only occupies about 1% of scoring period while 99% is occupied by GC. When the repetition is enlarged a lot, node21 downgration was fixed. benchmark@benchmark-S2600WFT:~/luc/node_new$ /home/benchmark/.nvm/versions/node/v20.10.0/bin/node benchmark/async_hooks/async-local-storage-getstore-nested-resources.js async_hooks/async-local-storage-getstore-nested-resources.js n=500000 resourceCount=10: 186,648,648.85043097 async_hooks/async-local-storage-getstore-nested-resources.js n=500000 resourceCount=100: 196,515,698.066993 async_hooks/async-local-storage-getstore-nested-resources.js n=500000 resourceCount=1000: 200,298,043.4887112 benchmark@benchmark-S2600WFT:~/luc/node_new$ /home/benchmark/.nvm/versions/node/v16.20.2/bin/node benchmark/async_hooks/async-local-storage-getstore-nested-resources.js async_hooks/async-local-storage-getstore-nested-resources.js n=500000 resourceCount=10: 172,352,994.0989782 async_hooks/async-local-storage-getstore-nested-resources.js n=500000 resourceCount=100: 175,277,771.4483027 async_hooks/async-local-storage-getstore-nested-resources.js n=500000 resourceCount=1000: 164,489,213.29086003 |
Sorry, something went wrong.
legendecas
approved these changes
Mar 1, 2024
Copy link
Copy Markdown
Member
|
Would you mind rebasing on top of the main branch? One of the GitHub actions failed but I can not restart it. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
sure I will rebase |
Sorry, something went wrong.
storage-getstore-nested-resources.js Fixes: nodejs#50571
lucshi
force-pushed
the
async_hooks/async-local-storage-getstore-nested-resources.js
branch
from
5156af6 to
13b615c
Compare
March 1, 2024 13:25
legendecas
approved these changes
Mar 4, 2024
UlisesGascon
approved these changes
Mar 4, 2024
lucshi
deleted the
async_hooks/async-local-storage-getstore-nested-resources.js
branch
March 5, 2024 01:19
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
storage-getstore-nested-resources.js
Before applying this PR, the real logic code of "aync hooks" is not measured accurately.
<style> </style>After increasing the iteration value, the test case behavior made sense.