FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: do not access process.noDeprecation at build time by joyeecheung · Pull Request #51447 · nodejs/node · GitHub

/ node Public

lib: do not access process.noDeprecation at build time - #51447

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:no-deprecate
Feb 26, 2024
ConversationCommits (1)ChecksFiles changed
Merged

lib: do not access process.noDeprecation at build time#51447
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:no-deprecate

Conversation

joyeecheung commented Jan 13, 2024

Copy link
Copy Markdown
Member

Delay access at run time otherwise the value is captured at build time and always false.

nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Jan 13, 2024
joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2024

nodejs-github-bot commented Jan 13, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56765/

targos commented Jan 13, 2024

Copy link
Copy Markdown
Member

Can you add a test ?

anonrig reviewed Jan 13, 2024
View reviewed changes
Comment thread lib/internal/fs/utils.js Outdated
legendecas reviewed Jan 15, 2024
View reviewed changes
Comment thread lib/internal/util.js Outdated
joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2024
targos previously requested changes Jan 16, 2024
View reviewed changes

targos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you add a test ?

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2024

nodejs-github-bot commented Jan 16, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56811/

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2024

nodejs-github-bot commented Jan 22, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56876/

joyeecheung commented Jan 31, 2024

Copy link
Copy Markdown
Member Author

Can you add a test ?

@targos I don't think we can reliably test this because this requires accessing something that we are not supposed to access in the snapshot i.e. before the test is run.

targos dismissed their stale review February 1, 2024 13:06

addressed

nodejs-github-bot commented Feb 2, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57022/

nodejs-github-bot commented Feb 2, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57028/

lib: do not access process.noDeprecation at build time
3160cfe 
Delay access at run time otherwise the value is captured at build
time and always false.

nodejs-github-bot commented Feb 16, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57144/

MrJithil reviewed Feb 17, 2024
View reviewed changes
Comment thread lib/internal/fs/utils.js
function emitRecursiveRmdirWarning() {
if (recursiveRmdirWarned === undefined) {
// TODO(joyeecheung): use getOptionValue('--no-deprecation') instead.
recursiveRmdirWarned = process.noDeprecation;

MrJithil Feb 17, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

recursiveRmdirWarned = recursiveRmdirWarned || process.noDeprecation;

joyeecheung Feb 17, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think that would make the code harder to understand when we are lazily initializing a boolean.

nodejs-github-bot commented Feb 17, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57159/

nodejs-github-bot commented Feb 20, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57193/

nodejs-github-bot commented Feb 20, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57210/

nodejs-github-bot commented Feb 21, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57227/

nodejs-github-bot commented Feb 21, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57229/

legendecas commented Feb 21, 2024

Copy link
Copy Markdown
Member

#51813 failed across multiple PRs.

nodejs-github-bot commented Feb 21, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57256/

nodejs-github-bot commented Feb 21, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57271/

nodejs-github-bot commented Feb 22, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57280/

nodejs-github-bot commented Feb 22, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57281/

nodejs-github-bot commented Feb 22, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57291/

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2024

nodejs-github-bot commented Feb 22, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57314/

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 25, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 25, 2024

nodejs-github-bot commented Feb 25, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57416/

nodejs-github-bot commented Feb 26, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57421/

legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 26, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 26, 2024
nodejs-github-bot merged commit 9ac98b1 into nodejs:main Feb 26, 2024

nodejs-github-bot commented Feb 26, 2024

Copy link
Copy Markdown
Collaborator

Landed in 9ac98b1

marco-ippolito pushed a commit that referenced this pull request Feb 26, 2024
lib: do not access process.noDeprecation at build time
ecabf88 
Delay access at run time otherwise the value is captured at build
time and always false.

PR-URL: #51447
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Feb 27, 2024
lib: do not access process.noDeprecation at build time
eb1089a 
Delay access at run time otherwise the value is captured at build
time and always false.

PR-URL: #51447
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
lib: do not access process.noDeprecation at build time
9082cc5 
Delay access at run time otherwise the value is captured at build
time and always false.

PR-URL: #51447
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
richardlau mentioned this pull request Mar 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig left review comments
MrJithil MrJithil approved these changes
benjamingr benjamingr approved these changes
lpinca lpinca approved these changes
legendecas legendecas approved these changes
aduh95 aduh95 approved these changes
+1 more reviewer
targos targos left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL