tools: limit parallelism with ninja in V8 builds - #51473
Merged
nodejs-github-bot merged 1 commit intoJan 17, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
richardlau
force-pushed
the
parallel-ninja
branch
from
be40d25 to
cde1a9d
Compare
January 15, 2024 17:51
This comment was marked as outdated.
richardlau
force-pushed
the
parallel-ninja
branch
from
cde1a9d to
1ce796e
Compare
January 15, 2024 17:55
If `JOBS` has been set in the environment to limit build parallelism, pass that onto `ninja` when building V8.
richardlau
force-pushed
the
parallel-ninja
branch
from
1ce796e to
c6ebd02
Compare
January 15, 2024 18:00
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
anonrig
approved these changes
Jan 15, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
approved these changes
Jan 16, 2024
aymen94
approved these changes
Jan 16, 2024
lpinca
approved these changes
Jan 16, 2024
mhdawson
approved these changes
Jan 16, 2024
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Medhansh404
pushed a commit
to Medhansh404/node
that referenced
this pull request
Jan 19, 2024
If `JOBS` has been set in the environment to limit build parallelism, pass that onto `ninja` when building V8. PR-URL: nodejs#51473 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Jan 22, 2024
If `JOBS` has been set in the environment to limit build parallelism, pass that onto `ninja` when building V8. PR-URL: nodejs#51473 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
targos
pushed a commit
that referenced
this pull request
Feb 15, 2024
If `JOBS` has been set in the environment to limit build parallelism, pass that onto `ninja` when building V8. PR-URL: #51473 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
richardlau
added a commit
that referenced
this pull request
Mar 25, 2024
If `JOBS` has been set in the environment to limit build parallelism, pass that onto `ninja` when building V8. PR-URL: #51473 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If JOBS has been set in the environment to limit build parallelism, pass that onto ninja when building V8.
Refs: #51362 (comment)