FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Allow checking the test result from afterEach by tims-bsquare · Pull Request #51485 · nodejs/node · GitHub

/ node Public

Allow checking the test result from afterEach - #51485

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
tims-bsquare:test-after-each-access-result
Jan 19, 2024
ConversationCommits (2)ChecksFiles changed
Merged

Allow checking the test result from afterEach#51485
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
tims-bsquare:test-after-each-access-result

Conversation

tims-bsquare commented Jan 16, 2024

Copy link
Copy Markdown
Contributor

This lets users check the result of the test in the afterEach hook. It's handy for example when doing Selenium tests where if a test fails you want to take a screenshot then do some cleanup.

nodejs-github-bot commented Jan 16, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jan 16, 2024
tims-bsquare force-pushed the test-after-each-access-result branch from 9a559a9 to f748568 Compare January 16, 2024 13:57

tims-bsquare commented Jan 16, 2024

Copy link
Copy Markdown
Contributor Author

Amended the commit message to match guidelines

MoLow reviewed Jan 16, 2024
View reviewed changes
Comment thread lib/internal/test_runner/test.js Outdated
tims-bsquare requested a review from MoLow January 17, 2024 09:32
MoLow added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 18, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 18, 2024

nodejs-github-bot commented Jan 18, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56830/

aduh95 reviewed Jan 18, 2024
View reviewed changes
Comment thread lib/internal/test_runner/test.js
tims-bsquare requested a review from aduh95 January 18, 2024 13:21

nodejs-github-bot commented Jan 19, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56839/

nodejs-github-bot commented Jan 19, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56841/

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 19, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 19, 2024
nodejs-github-bot merged commit d755f1a into nodejs:main Jan 19, 2024

nodejs-github-bot commented Jan 19, 2024

Copy link
Copy Markdown
Collaborator

Landed in d755f1a

marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 22, 2024
lib: allow checking the test result from afterEach
1de04f7 
PR-URL: nodejs#51485
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos pushed a commit that referenced this pull request Feb 15, 2024
lib: allow checking the test result from afterEach
4b583bf 
PR-URL: #51485
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
lib: allow checking the test result from afterEach
da79876 
PR-URL: #51485
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
richardlau mentioned this pull request Mar 25, 2024
Merged
This was referenced Aug 1, 2025
Closed
Closed
Xstoudi mentioned this pull request Dec 28, 2025
Merged
Xstoudi added a commit to Xstoudi/node that referenced this pull request Dec 28, 2025
doc: missing passed, error and passed properties on TestContext
addfc94 
`passed` and `error` properties were left undocumented on `TextContext`
class

Fixes: nodejs#59321
Refs: nodejs#51485
Refs: nodejs#59322

Co-authored-by: SimonSchick <demwizzy@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Dec 30, 2025
doc: missing passed, error and passed properties on TestContext
20bf328 
`passed` and `error` properties were left undocumented on `TextContext`
class

Fixes: #59321
Refs: #51485
Refs: #59322

Co-authored-by: SimonSchick <demwizzy@gmail.com>
PR-URL: #61185
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request Jan 9, 2026
doc: missing passed, error and passed properties on TestContext
2ea1794 
`passed` and `error` properties were left undocumented on `TextContext`
class

Fixes: #59321
Refs: #51485
Refs: #59322

Co-authored-by: SimonSchick <demwizzy@gmail.com>
PR-URL: #61185
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request Jan 12, 2026
doc: missing passed, error and passed properties on TestContext
ab36966 
`passed` and `error` properties were left undocumented on `TextContext`
class

Fixes: #59321
Refs: #51485
Refs: #59322

Co-authored-by: SimonSchick <demwizzy@gmail.com>
PR-URL: #61185
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 13, 2026
doc: missing passed, error and passed properties on TestContext
72f42b9 
`passed` and `error` properties were left undocumented on `TextContext`
class

Fixes: #59321
Refs: #51485
Refs: #59322

Co-authored-by: SimonSchick <demwizzy@gmail.com>
PR-URL: #61185
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request Jan 19, 2026
doc: missing passed, error and passed properties on TestContext
816ce75 
`passed` and `error` properties were left undocumented on `TextContext`
class

Fixes: #59321
Refs: #51485
Refs: #59322

Co-authored-by: SimonSchick <demwizzy@gmail.com>
PR-URL: #61185
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 17, 2026
doc: missing passed, error and passed properties on TestContext
14c8ddd 
`passed` and `error` properties were left undocumented on `TextContext`
class

Fixes: #59321
Refs: #51485
Refs: #59322

Co-authored-by: SimonSchick <demwizzy@gmail.com>
PR-URL: #61185
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 19, 2026
doc: missing passed, error and passed properties on TestContext
4db947e 
`passed` and `error` properties were left undocumented on `TextContext`
class

Fixes: #59321
Refs: #51485
Refs: #59322

Co-authored-by: SimonSchick <demwizzy@gmail.com>
PR-URL: #61185
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 21, 2026
doc: missing passed, error and passed properties on TestContext
622c5f6 
`passed` and `error` properties were left undocumented on `TextContext`
class

Fixes: #59321
Refs: #51485
Refs: #59322

Co-authored-by: SimonSchick <demwizzy@gmail.com>
PR-URL: #61185
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 23, 2026
doc: missing passed, error and passed properties on TestContext
e7b34b7 
`passed` and `error` properties were left undocumented on `TextContext`
class

Fixes: #59321
Refs: #51485
Refs: #59322

Co-authored-by: SimonSchick <demwizzy@gmail.com>
PR-URL: #61185
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

MoLow MoLow approved these changes
benjamingr benjamingr approved these changes
aduh95 Awaiting requested review from aduh95

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL