stream: fix cloned webstreams not being unref correctly - #51526
Merged
nodejs-github-bot merged 1 commit intoJan 23, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mcollina
approved these changes
Jan 19, 2024
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Merged
tsctx
force-pushed
the
fix/webstreams-clone-hang
branch
from
014f1ea to
0530d58
Compare
January 20, 2024 13:49
tsctx
commented
Jan 20, 2024
Comment thread
lib/internal/webstreams/writablestream.js
H4ad
approved these changes
Jan 22, 2024
Copy link
Copy Markdown
Member
|
@mcollina Should we fast track in favor of #51530 (comment)? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
This doesn't need a fast track as it was opened >48 hours ago and has the required number of reviews. It does need a passing CI run, which I see has been requested. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@nodejs/build The fedora machines are failling in the latest jobs: 11:40:02 ERROR: Error cloning remote repo 'origin' 11:40:02 hudson.plugins.git.GitException: Could not init /home/iojs/build/workspace/node-test-commit-linux 11:40:02 at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$5.execute(CliGitAPIImpl.java:1073) 11:40:02 at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:819) 11:40:02 at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:170) 11:40:02 at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161) 11:40:02 at hudson.remoting.UserRequest.perform(UserRequest.java:211) 11:40:02 at hudson.remoting.UserRequest.perform(UserRequest.java:54) 11:40:02 at hudson.remoting.Request$2.run(Request.java:377) 11:40:02 at hudson.remoting.InterceptingExecutorService.lambda$wrap$0(InterceptingExecutorService.java:78) 11:40:02 at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) 11:40:02 at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) 11:40:02 at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) 11:40:02 at hudson.remoting.Engine$1.lambda$newThread$0(Engine.java:125) 11:40:02 at java.base/java.lang.Thread.run(Thread.java:833) 11:40:02 Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Looks like the git clone is corrupt on test-digitalocean-fedora38-x64-2. I wiped out the workspace. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Feb 15, 2024
PR-URL: #51526 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51526 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44985.
Fixed a problem where the process would not terminate if structuredClone was used for webstream and body was not consumed.
The issue with #51255 has been fixed and adjusted so that #51486 does not happen.