FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: set normalizeTD text default to empty string by marco-ippolito · Pull Request #51543 · nodejs/node · GitHub

/ node Public

tools: set normalizeTD text default to empty string - #51543

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:fix/update-root-certs
Jan 24, 2024
ConversationCommits (1)ChecksFiles changed
Merged

tools: set normalizeTD text default to empty string#51543
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:fix/update-root-certs

Conversation

marco-ippolito commented Jan 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

nodejs-github-bot commented Jan 22, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 22, 2024
marco-ippolito added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 22, 2024
marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 23, 2024
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 24, 2024

nodejs-github-bot commented Jan 24, 2024

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/51543
✔  Done loading data for nodejs/node/pull/51543
----------------------------------- PR info ------------------------------------
Title      tools: set normalizeTD text default to empty string (#51543)
Author     Marco Ippolito  (@marco-ippolito)
Branch     marco-ippolito:fix/update-root-certs -> nodejs:main
Labels     tools, author ready
Commits    1
 - tools: set normalizeTD text default to empty string
Committers 1
 - marco-ippolito 
PR-URL: https://github.com/nodejs/node/pull/51543
Fixes: https://github.com/nodejs/node/actions/runs/7597757959/job/20692964963
Reviewed-By: Richard Lau 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51543
Fixes: https://github.com/nodejs/node/actions/runs/7597757959/job/20692964963
Reviewed-By: Richard Lau 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 22 Jan 2024 17:26:56 GMT
   ✔  Approvals: 3
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/51543#pullrequestreview-1837150227
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51543#pullrequestreview-1837297960
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/51543#pullrequestreview-1837700370
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 51543
From https://github.com/nodejs/node
 * branch                  refs/pull/51543/merge -> FETCH_HEAD
✔  Fetched commits as 925a464cb8ba..f1867bca157f
--------------------------------------------------------------------------------
[main b19e19e8b3] tools: set normalizeTD text default to empty string
 Author: marco-ippolito 
 Date: Mon Jan 22 18:25:23 2024 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
tools: set normalizeTD text default to empty string

PR-URL: #51543

Fixes: https://github.com/nodejs/node/actions/runs/7597757959/job/20692964963

Reviewed-By: Richard Lau rlau@redhat.com

Reviewed-By: Luigi Pinca luigipinca@gmail.com

Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io


[main 6c4fda3f52] tools: set normalizeTD text default to empty string

Author: marco-ippolito marcoippolito54@gmail.com

Date: Mon Jan 22 18:25:23 2024 +0100

1 file changed, 1 insertion(+), 1 deletion(-)

✖  6c4fda3f52c72c9acbd2a7762f15374db7259c7f

✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer

✖  2:7      Fixes must be a GitHub URL.               fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  1:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✔  0:0      valid subsystems                          subsystem

✔  0:0      Title is formatted correctly.             title-format

⚠  0:50     Title should be <= 50 columns.            title-length


ℹ  Please fix the commit message and try again.

Please manually ammend the commit message, by running

git commit --amend

Once commit message is fixed, finish the landing command running

git node land --continue
https://github.com/nodejs/node/actions/runs/7643958471

marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 24, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 24, 2024
nodejs-github-bot merged commit d8e385a into nodejs:main Jan 24, 2024

nodejs-github-bot commented Jan 24, 2024

Copy link
Copy Markdown
Collaborator

Landed in d8e385a

richardlau commented Jan 24, 2024

Copy link
Copy Markdown
Member

Test run: https://github.com/nodejs/node/actions/runs/7644481671/job/20828901150

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Feb 9, 2024
tools: set normalizeTD text default to empty string
942125a 
PR-URL: nodejs#51543
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
targos pushed a commit that referenced this pull request Feb 15, 2024
tools: set normalizeTD text default to empty string
e0eeebc 
PR-URL: #51543
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
tools: set normalizeTD text default to empty string
ce49cb6 
PR-URL: #51543
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
richardlau mentioned this pull request Mar 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
anonrig anonrig approved these changes
richardlau richardlau approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL