FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v21.x backport] url: don't update URL immediately on update to URLSearchParams by MattIPv4 · Pull Request #51559 · nodejs/node · GitHub

/ node Public

[v21.x backport] url: don't update URL immediately on update to URLSearchParams - #51559

Merged
targos merged 1 commit into
nodejs:v21.x-stagingfrom
MattIPv4:backport-url-params-perf
Feb 15, 2024
ConversationCommits (1)ChecksFiles changed
Merged

[v21.x backport] url: don't update URL immediately on update to URLSearchParams#51559
targos merged 1 commit into
nodejs:v21.x-stagingfrom
MattIPv4:backport-url-params-perf

Conversation

MattIPv4 commented Jan 24, 2024

Copy link
Copy Markdown
Member

Backport for #51520, fixing the commit message to match the PR title rather than the misleading initial commit message.

nodejs-github-bot commented Jan 24, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/url

nodejs-github-bot added needs-ci PRs that need a full CI run. v21.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Jan 24, 2024
url: don't update URL immediately on update to URLSearchParams
6e04e1f 
PR-URL: #51520
Fixes: #51518
Backport-PR-URL: #51559
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos merged commit 407341e into nodejs:v21.x-staging Feb 15, 2024

targos commented Feb 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Thank you! Since the only change compared to what's on main is the commit message, I merged the PR directly.

richardlau pushed a commit that referenced this pull request Mar 25, 2024
url: don't update URL immediately on update to URLSearchParams
4bc8e98 
PR-URL: #51520
Fixes: #51518
Backport-PR-URL: #51559
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL