doc: updates for better json generating - #51592
Merged
nodejs-github-bot merged 1 commit intoFeb 13, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Semigradsky
force-pushed
the
update-docs
branch
from
8566f41 to
fbf9231
Compare
January 29, 2024 10:48
Copy link
Copy Markdown
Contributor
|
@aduh95 This looks fine to me in general. Do we have any tool that would be broken by this? |
Sorry, something went wrong.
atlowChemi
approved these changes
Jan 29, 2024
Comment thread
doc/api/fs.md
Outdated
Comment thread
doc/api/fs.md
Outdated
Comment thread
doc/api/webcrypto.md
Outdated
Comment thread
doc/api/webcrypto.md
Outdated
aduh95
reviewed
Jan 29, 2024
Comment thread
doc/api/crypto.md
Outdated
lpinca
approved these changes
Jan 30, 2024
aduh95
reviewed
Jan 31, 2024
Comment thread
doc/api/crypto.md
Outdated
Semigradsky
force-pushed
the
update-docs
branch
from
5fcf923 to
2e80968
Compare
February 1, 2024 10:03
panva
approved these changes
Feb 3, 2024
targos
pushed a commit
that referenced
this pull request
Feb 15, 2024
PR-URL: #51592 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51592 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E.g. for tracker.calls([fn][, exact]) from doc/api/assert.md we currently have:
The return.desc doesn't explain return type.
So I made a change: