tools: only run build-windows workflow on source changes - #51596
Merged
nodejs-github-bot merged 2 commits intoJan 31, 2024
Merged
tools: only run build-windows workflow on source changes#51596nodejs-github-bot merged 2 commits into
nodejs-github-bot merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
aduh95
force-pushed
the
build-windows-sometimes
branch
from
4c4d0cf to
ee46d05
Compare
January 29, 2024 14:51
MoLow
approved these changes
Jan 29, 2024
marco-ippolito
approved these changes
Jan 29, 2024
aduh95
commented
Jan 29, 2024
Comment thread
.github/workflows/build-windows.yml
Outdated
Comment thread
.github/workflows/build-windows.yml
Outdated
bnb
approved these changes
Jan 29, 2024
lpinca
approved these changes
Jan 29, 2024
anonrig
approved these changes
Jan 29, 2024
StefanStojanovic
approved these changes
Jan 30, 2024
Copy link
Copy Markdown
Member
FWIW there is an open issue on running the tests as well for Windows on the GitHub runners: #50489 |
Sorry, something went wrong.
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Feb 9, 2024
PR-URL: nodejs#51596 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
targos
pushed a commit
that referenced
this pull request
Feb 15, 2024
PR-URL: #51596 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Merged
Copy link
Copy Markdown
Member
|
This prevents build-windows to run on build configuration changes (for example gyp file updates like #52083) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
It also doesn't run when deps are updated: #51362 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Those sound like good reasons to revert this. |
Sorry, something went wrong.
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51596 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this workflow does not run any tests, it doesn't really makes sense to have it run on doc-only changes, or test-only changes.
I took inspiration for the list of paths from
node/.github/workflows/coverage-windows.yml
Lines 6 to 14 in 084d761