build: use macOS m1 machines for testing - #51620
Conversation
Sorry, something went wrong.
|
Review requested:
|
Sorry, something went wrong.
|
FWIW https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/ says that even if we were to stay on macos-latest, that will be switched to macOS 14 M1 later in the year. |
Sorry, something went wrong.
That's the build time, worth noting the test time has also decreased with this PR (from 27min down to 16min), quite impressive. It makes me wonder if we should switch to macOS job to run tests faster on doc-only PRs (we probably should not, the number of macOS runners is way more limited than the number of linux ones) |
Sorry, something went wrong.
mhdawson
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
UlisesGascon
left a comment
There was a problem hiding this comment.
LGTM! 🚀
Sorry, something went wrong.
bnb
left a comment
There was a problem hiding this comment.
hell yeah
Sorry, something went wrong.
PR-URL: nodejs#51620 Refs: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/ Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
PR-URL: #51620 Refs: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/ Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
PR-URL: #51620 Refs: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/ Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
macOS-14 now uses M1 machines. Let's see if the build speed and duration is worth the change.
Ref: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/
cc @nodejs/build
macOS-14: 27m
macOS-latest: 1h 18m