| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Will add test cases if this feature is acceptable |
Sorry, something went wrong.
|
@MoLow I have changed the value of clear from '\u001bc' to '\u001b[0m'. Please check. |
Sorry, something went wrong.
|
I believe it's important to run through citgm to gauge the impact of this change. |
Sorry, something went wrong.
|
I once again believe this should be marked as semver major change: #51503 |
Sorry, something went wrong.
Sorry, something went wrong.
Could you please help me to run this CIGTM? I haven't run this before and felt a little confusing. Since these tests are time consuming, thought to take help or opinion before retrying it. |
Sorry, something went wrong.
$ ncu-ci.js citgm 3421 3422
FAILURE: 6 failures in 3422 not present in 3421
┌────────────────────────┬──────────────────┬───────────────────────┐
│ (index) │ 0 │ 1 │
├────────────────────────┼──────────────────┼───────────────────────┤
│ osx11-x64 │ │ │
│ rhel8-s390x │ │ │
│ win-vs2022 │ │ │
│ alpine-last-latest-x64 │ │ │
│ rhel8-x64 │ 'undici-v6.14.1' │ │
│ debian12-x64 │ │ │
│ debian11-x64 │ 'jest-v0.0.0' │ 'semver-v7.6.0' │
│ fedora-latest-x64 │ │ │
│ rhel8-ppc64le │ 'pino-v8.19.0' │ 'prom-client-v15.1.2' │
│ aix72-ppc64 │ │ │
│ ubuntu2204-64 │ 'undici-v6.14.1' │ │
│ alpine-latest-x64 │ │ │
│ fedora-last-latest-x64 │ │ │
└────────────────────────┴──────────────────┴───────────────────────┘Now it's a matter of investigating whether those failures were caused by this PR or something else. For semver and prom-client, that's easy, No space left of device, so unrelated. For the other ones, it would require more careful review – but it seems fair to say landing this PR would not cause to much trouble to the ecosystem. |
Sorry, something went wrong.
prints console error in red and warn in yellow PR-URL: #51629 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: James M Snell <jasnell@gmail.com>
prints console error in red and warn in yellow PR-URL: #51629 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Updated node to latest version, but console.error still outputs unclolored text. Is there any configuration required to achieve this? |
Sorry, something went wrong.
prints console error in red and warn in yellow PR-URL: #51629 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: James M Snell <jasnell@gmail.com>
prints console error in red and warn in yellow PR-URL: nodejs#51629 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: James M Snell <jasnell@gmail.com>
|
I'm a bit surprised that this landed without a link to the discussion. #40361 is a feature request, but doesn't have a real discussion around the pros/cons and how it will impact the nodejs ecosystem. I would have rather seen color added to the formatting of Errors instead of blanket red/yellow for console.error/console.warn. I realize that in some way, this PR makes the behavior closer to that in the browser, but browsers do not have CLI applications. I treat console.log and console.error as separate channels. Traditionally stdout is used for output of the program. It contains the result to be used, think grep. stderr is used for diagnostics, status, and messages to the user while the application is running. Color is not implied. I would rather that this PR implemented color as a opt in vs trying to figure out how to opt out. |
Sorry, something went wrong.
Recent versions of Node.js [print console.error() in red](nodejs/node#51629), changing the color of convex CLI output unintentionally. Change everywhere we `console.error` as a means to write to stderr to `process.stderr.write` calls. GitOrigin-RevId: 134e5302858c309e3a7fd9d470a685d9bf60b1df
Recent versions of Node.js [print console.error() in red](nodejs/node#51629), changing the color of convex CLI output unintentionally. Change everywhere we `console.error` as a means to write to stderr to `process.stderr.write` calls. GitOrigin-RevId: 134e5302858c309e3a7fd9d470a685d9bf60b1df
The output of console.Console is colorized in Node.js >=20.15 <22.10 due to nodejs/node#51629 and nodejs/node#54677. Handle this in our test cases by comparing the output to the output of console.Console on a PassThrough stream. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
| Back | FazBrowse Home | New Git URL |
Related to : 40361
Colorise string type args of console.error and console.warn. We are skipping the non-string types.
Tasks: