report: add --report-exclude-network option - #51645
Merged
nodejs-github-bot merged 1 commit intoMar 1, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Ethan-Arrowood
force-pushed
the
fix/process-getreport
branch
from
8b03a57 to
0f094cb
Compare
February 2, 2024 03:21
Ethan-Arrowood
marked this pull request as ready for review
February 2, 2024 03:21
Copy link
Copy Markdown
Contributor
Author
|
I'm not used to the tests not being in either sequential or parallel. I add some more tests that verify the header.networkInterfaces is missing when this option is set (either by CLI or configuration). I used new test syntax and what not so hopefully that still works in the test/report/ directory. |
Sorry, something went wrong.
anonrig
self-requested a review
February 2, 2024 03:39
Ethan-Arrowood
force-pushed
the
fix/process-getreport
branch
2 times, most recently
from
8341898 to
1f12672
Compare
February 2, 2024 04:18
joyeecheung
reviewed
Feb 2, 2024
styfle
reviewed
Feb 2, 2024
Comment thread
test/report/test-report-disable-network.js
Outdated
anonrig
reviewed
Feb 2, 2024
Comment thread
doc/api/report.md
Outdated
Comment thread
lib/internal/process/report.js
Outdated
Comment thread
src/node_report.cc
Outdated
Comment thread
src/node_report.cc
Outdated
Comment thread
src/node_report.cc
Outdated
Comment thread
test/report/test-report-config.js
Outdated
Ethan-Arrowood
force-pushed
the
fix/process-getreport
branch
from
43125e2 to
2d5fb4e
Compare
February 5, 2024 20:21
Ethan-Arrowood
force-pushed
the
fix/process-getreport
branch
from
2d5fb4e to
25be48a
Compare
February 5, 2024 20:28
Ethan-Arrowood
force-pushed
the
fix/process-getreport
branch
from
0ca3be5 to
e485abb
Compare
February 5, 2024 20:36
anonrig
approved these changes
Feb 5, 2024
Copy link
Copy Markdown
Contributor
|
The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @anonrig. Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@anonrig I'm getting a segmentation fault now (after I made the change Joyee recommended). Trying to debug but this is hard |
Sorry, something went wrong.
Ethan-Arrowood
commented
Feb 6, 2024
Comment thread
src/node_report_module.cc
Outdated
richardlau
reviewed
Feb 6, 2024
Comment thread
doc/api/report.md
Outdated
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/51645 ✔ Done loading data for nodejs/node/pull/51645 ----------------------------------- PR info ------------------------------------ Title report: add `--report-exclude-network` option (#51645) Author Ethan Arrowood (@Ethan-Arrowood) Branch Ethan-Arrowood:fix/process-getreport -> nodejs:main Labels c++, semver-minor, lib / src, notable-change, needs-ci, report Commits 1 - report: add `--report-exclude-network` option Committers 1 - Ethan Arrowood PR-URL: https://github.com/nodejs/node/pull/51645 Fixes: https://github.com/nodejs/node/issues/46060 Reviewed-By: Yagiz Nizipli Reviewed-By: Joyee Cheung ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51645 Fixes: https://github.com/nodejs/node/issues/46060 Reviewed-By: Yagiz Nizipli Reviewed-By: Joyee Cheung -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - report: add `--report-exclude-network` option ℹ This PR was created on Fri, 02 Feb 2024 03:17:12 GMT ✔ Approvals: 2 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/51645#pullrequestreview-1864004600 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51645#pullrequestreview-1881176781 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2024-02-15T15:18:08Z: https://ci.nodejs.org/job/node-test-pull-request/57100/ - Querying data for job/node-test-pull-request/57100/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/7923747889 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
New option `--report-exclude-network`, also available as `report.excludeNetwork`, enables the user to exclude networking interfaces in their diagnostic report. On some systems, this can cause the report to take minutes to generate so this option can be used to optimize that. Fixes: nodejs#46060 PR-URL: nodejs#51645 Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
Ethan-Arrowood
force-pushed
the
fix/process-getreport
branch
from
99d022c to
67ca735
Compare
February 21, 2024 17:13
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
If you like at all of the CI runs for this PR it has only failed flaky tests. There is nothing failing consistently, so I believe this is safe to land |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/51645 ✔ Done loading data for nodejs/node/pull/51645 ----------------------------------- PR info ------------------------------------ Title report: add `--report-exclude-network` option (#51645) Author Ethan Arrowood (@Ethan-Arrowood) Branch Ethan-Arrowood:fix/process-getreport -> nodejs:main Labels c++, semver-minor, lib / src, notable-change, needs-ci, report Commits 1 - report: add `--report-exclude-network` option Committers 1 - Ethan Arrowood PR-URL: https://github.com/nodejs/node/pull/51645 Fixes: https://github.com/nodejs/node/issues/46060 Reviewed-By: Yagiz Nizipli Reviewed-By: Joyee Cheung ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51645 Fixes: https://github.com/nodejs/node/issues/46060 Reviewed-By: Yagiz Nizipli Reviewed-By: Joyee Cheung -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - report: add `--report-exclude-network` option ℹ This PR was created on Fri, 02 Feb 2024 03:17:12 GMT ✔ Approvals: 2 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/51645#pullrequestreview-1864004600 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51645#pullrequestreview-1881176781 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-03-01T16:27:31Z: https://ci.nodejs.org/job/node-test-pull-request/57536/ - Querying data for job/node-test-pull-request/57536/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8114994573 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Commit-queue failed because I pushed a rebase after latest reviews. Can someone reapprove this please? @anonrig @joyeecheung |
Sorry, something went wrong.
joyeecheung
approved these changes
Mar 1, 2024
1 task
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New option --report-exclude-network, also available as report.excludeNetwork, enables the user to exclude networking interfaces in their diagnostic report. On some systems, this can cause the report to take minutes to generate so this option can be used to optimize that.
Fixes: #46060