http: split set-cookie when using setHeaders - #51649
Merged
nodejs-github-bot merged 2 commits intoFeb 4, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
marco-ippolito
force-pushed
the
feat/set-headers-cookies
branch
from
a6ad1c6 to
ab75703
Compare
February 2, 2024 11:41
ShogunPanda
approved these changes
Feb 2, 2024
ShogunPanda
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
mcollina
reviewed
Feb 2, 2024
Comment thread
lib/_http_outgoing.js
Outdated
marco-ippolito
force-pushed
the
feat/set-headers-cookies
branch
from
ab75703 to
ff72f2f
Compare
February 2, 2024 14:35
climba03003
reviewed
Feb 2, 2024
Comment thread
lib/_http_outgoing.js
Outdated
climba03003
reviewed
Feb 2, 2024
Comment thread
lib/_http_outgoing.js
Outdated
KhafraDev
reviewed
Feb 2, 2024
Comment thread
lib/_http_outgoing.js
Outdated
marco-ippolito
force-pushed
the
feat/set-headers-cookies
branch
from
ff72f2f to
330e8bb
Compare
February 2, 2024 17:00
marco-ippolito
force-pushed
the
feat/set-headers-cookies
branch
from
330e8bb to
094349f
Compare
February 3, 2024 08:14
lpinca
approved these changes
Feb 3, 2024
ShogunPanda
approved these changes
Feb 3, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
marsonya
approved these changes
Feb 3, 2024
Comment thread
lib/_http_outgoing.js
Outdated
Co-authored-by: akhil marsonya <16393876+marsonya@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
JungMinu
approved these changes
Feb 4, 2024
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/51649 ✔ Done loading data for nodejs/node/pull/51649 ----------------------------------- PR info ------------------------------------ Title http: split set-cookie when using setHeaders (#51649) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:feat/set-headers-cookies -> nodejs:main Labels http, author ready Commits 2 - http: split set-cookie when using setHeaders - Update lib/_http_outgoing.js Committers 2 - marco-ippolito - GitHub PR-URL: https://github.com/nodejs/node/pull/51649 Fixes: https://github.com/nodejs/node/issues/51599 Reviewed-By: Paolo Insogna Reviewed-By: Luigi Pinca Reviewed-By: Akhil Marsonya Reviewed-By: Minwoo Jung ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51649 Fixes: https://github.com/nodejs/node/issues/51599 Reviewed-By: Paolo Insogna Reviewed-By: Luigi Pinca Reviewed-By: Akhil Marsonya Reviewed-By: Minwoo Jung -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 02 Feb 2024 11:18:39 GMT ✔ Approvals: 4 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/51649#pullrequestreview-1860949554 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51649#pullrequestreview-1860948676 ✔ - Akhil Marsonya (@marsonya): https://github.com/nodejs/node/pull/51649#pullrequestreview-1860999209 ✔ - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/51649#pullrequestreview-1861448465 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-02-04T09:38:30Z: https://ci.nodejs.org/job/node-test-pull-request/57047/ - Querying data for job/node-test-pull-request/57047/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 51649 From https://github.com/nodejs/node * branch refs/pull/51649/merge -> FETCH_HEAD ✔ Fetched commits as c975384264dc..d546c502a56e -------------------------------------------------------------------------------- [main 4c1cc83b8f] http: split set-cookie when using setHeaders Author: marco-ippolito Date: Fri Feb 2 11:55:37 2024 +0100 2 files changed, 64 insertions(+), 2 deletions(-) [main 918a9ad1d1] Update lib/_http_outgoing.js Author: Marco Ippolito Date: Sat Feb 3 12:23:09 2024 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/7775666607 |
Sorry, something went wrong.
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Feb 9, 2024
PR-URL: nodejs#51649 Fixes: nodejs#51599 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #51599
This allows set-cookie header to work correctly with setHeaders