src: check empty before accessing string - #51665
Merged
nodejs-github-bot merged 1 commit intoFeb 16, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
zcbenz
force-pushed
the
fix-str-front-assert
branch
from
22199ff to
7da4605
Compare
February 5, 2024 01:32
zcbenz
marked this pull request as draft
February 5, 2024 01:39
Fix an assertion when running dotnev tests with GN build: assertion !empty() failed: string::front(): string is empty which was caused by calling value.front() without verifying the value is not empty.
zcbenz
force-pushed
the
fix-str-front-assert
branch
from
7da4605 to
b208e65
Compare
February 5, 2024 01:46
zcbenz
marked this pull request as ready for review
February 5, 2024 01:48
anonrig
approved these changes
Feb 5, 2024
anonrig
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice catch
Sorry, something went wrong.
marco-ippolito
approved these changes
Feb 5, 2024
lpinca
approved these changes
Feb 5, 2024
Flarna
approved these changes
Feb 8, 2024
Copy link
Copy Markdown
Contributor
Author
|
Can this be merged? It is currently breaking GN build. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@zcbenz CI is currently locked for the security release |
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Feb 19, 2024
Fix an assertion when running dotnev tests with GN build: assertion !empty() failed: string::front(): string is empty which was caused by calling value.front() without verifying the value is not empty. PR-URL: #51665 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Fix an assertion when running dotnev tests with GN build: assertion !empty() failed: string::front(): string is empty which was caused by calling value.front() without verifying the value is not empty. PR-URL: #51665 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an assertion when running dotnev tests with GN build:
assertion !empty() failed: string::front(): string is empty
which was caused by calling value.front() without verifying the value is not empty.