FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove test-cli-node-options flaky designation by lpinca · Pull Request #51716 · nodejs/node · GitHub

/ node Public

test: remove test-cli-node-options flaky designation - #51716

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:remove/flaky-test-cli-node-options
Feb 17, 2024
ConversationCommits (1)ChecksFiles changed
Merged

test: remove test-cli-node-options flaky designation#51716
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:remove/flaky-test-cli-node-options

Conversation

lpinca commented Feb 10, 2024

Copy link
Copy Markdown
Member

The last trace of failure dates back to 2023-09-24.

Fixes: #50295

test: remove test-cli-node-options flaky designation
a6effb6 
The last trace of failure dates back to 2023-09-24.

Fixes: nodejs#50295
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 10, 2024
lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2024

nodejs-github-bot commented Feb 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57096/

nodejs-github-bot commented Feb 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57103/

nodejs-github-bot commented Feb 16, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57129/

nodejs-github-bot commented Feb 16, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57133/

nodejs-github-bot commented Feb 16, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57141/

nodejs-github-bot commented Feb 16, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57151/

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 17, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 17, 2024
nodejs-github-bot merged commit 6db72fc into nodejs:main Feb 17, 2024

nodejs-github-bot commented Feb 17, 2024

Copy link
Copy Markdown
Collaborator

Landed in 6db72fc

lpinca deleted the remove/flaky-test-cli-node-options branch February 17, 2024 17:02
targos pushed a commit that referenced this pull request Feb 19, 2024
test: remove test-cli-node-options flaky designation
ea08350 
The last trace of failure dates back to 2023-09-24.

Fixes: #50295
PR-URL: #51716
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
test: remove test-cli-node-options flaky designation
c33f860 
The last trace of failure dates back to 2023-09-24.

Fixes: #50295
PR-URL: #51716
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau mentioned this pull request Mar 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

parallel.test-cli-node-options is flaky

4 participants

Back | FazBrowse Home | New Git URL