FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove flaky designation by lpinca · Pull Request #51736 · nodejs/node · GitHub

/ node Public

test: remove flaky designation - #51736

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:remove/flaky-test-worker-message-port-message-before-close
Mar 2, 2024
ConversationCommits (1)ChecksFiles changed
Merged

test: remove flaky designation#51736
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:remove/flaky-test-worker-message-port-message-before-close

Conversation

lpinca commented Feb 12, 2024

Copy link
Copy Markdown
Member

Searching the automatically-generated test failure reports in the issues at https://github.com/nodejs/reliability/issues, I don't see test-worker-message-port-message-before-close failing any time recently.

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 12, 2024
lpinca force-pushed the remove/flaky-test-worker-message-port-message-before-close branch from 04fdef5 to d893058 Compare February 12, 2024 20:19

aduh95 commented Feb 12, 2024

Copy link
Copy Markdown
Contributor

Isn't it because of nodejs/build#3598?

lpinca commented Feb 13, 2024

Copy link
Copy Markdown
Member Author

There should be failures in https://github.com/nodejs/reliability/issues before nodejs/build#3598 landed, no?

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2024

nodejs-github-bot commented Feb 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57093/

nodejs-github-bot commented Feb 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57106/

nodejs-github-bot commented Feb 16, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57132/

test: remove flaky designation
ff2b674 
Searching the automatically-generated test failure reports in the issues
at https://github.com/nodejs/reliability/issues, I don't see
`test-worker-message-port-message-before-close` failing any time
recently.
lpinca force-pushed the remove/flaky-test-worker-message-port-message-before-close branch from d893058 to ff2b674 Compare February 22, 2024 18:36
lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2024

nodejs-github-bot commented Feb 22, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57302/

nodejs-github-bot commented Feb 24, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57387/

nodejs-github-bot commented Feb 26, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57441/

joyeecheung commented Feb 27, 2024

Copy link
Copy Markdown
Member

I don't think the reliability report considers tests that are marked as flaky: https://github.com/nodejs/node-core-utils/blob/0d49edaf6736b393b0597ee67d70381cd5841b40/lib/ci/ci_failure_parser.js#L157-L170 (perhaps we should, for the walk command used by the reliability report), but as far as I've seen it's not been failing recently.

nodejs-github-bot commented Feb 27, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57470/

nodejs-github-bot commented Feb 27, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57472/

nodejs-github-bot commented Feb 27, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57475/

nodejs-github-bot commented Feb 28, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57493/

nodejs-github-bot commented Feb 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57513/

nodejs-github-bot commented Feb 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57515/

nodejs-github-bot commented Mar 1, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57539/

nodejs-github-bot commented Mar 2, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57544/

nodejs-github-bot commented Mar 2, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57545/

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 2, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 2, 2024
nodejs-github-bot merged commit 5c97f41 into nodejs:main Mar 2, 2024

nodejs-github-bot commented Mar 2, 2024

Copy link
Copy Markdown
Collaborator

Landed in 5c97f41

lpinca deleted the remove/flaky-test-worker-message-port-message-before-close branch March 2, 2024 11:51
targos pushed a commit that referenced this pull request Mar 7, 2024
test: remove flaky designation
9d2c039 
Searching the automatically-generated test failure reports in the issues
at https://github.com/nodejs/reliability/issues, I don't see
`test-worker-message-port-message-before-close` failing any time
recently.

PR-URL: #51736
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos mentioned this pull request Mar 7, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
test: remove flaky designation
3f85c7a 
Searching the automatically-generated test failure reports in the issues
at https://github.com/nodejs/reliability/issues, I don't see
`test-worker-message-port-message-before-close` failing any time
recently.

PR-URL: #51736
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
richardlau mentioned this pull request Mar 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

joyeecheung joyeecheung approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL