FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix `globals.md` introduction by aduh95 · Pull Request #51742 · nodejs/node · GitHub

/ node Public

doc: fix globals.md introduction - #51742

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:fix-globals-intro
Feb 15, 2024
Merged

doc: fix globals.md introduction#51742
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:fix-globals-intro

Conversation

aduh95 commented Feb 13, 2024

Copy link
Copy Markdown
Contributor

Splitting the introduction sentence in two paragraphs so it's clearer the list of variables only apply to the second sentence.

Splitting the introduction sentence in two paragraphs so it's
clearer the list of variables only apply to the second sentence.
nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 13, 2024
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 13, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 15, 2024
nodejs-github-bot merged commit 10c6596 into nodejs:main Feb 15, 2024

Copy link
Copy Markdown
Collaborator

Landed in 10c6596

aduh95 deleted the fix-globals-intro branch February 15, 2024 10:28
targos pushed a commit that referenced this pull request Feb 15, 2024
Splitting the introduction sentence in two paragraphs so it's
clearer the list of variables only apply to the second sentence.

PR-URL: #51742
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito mentioned this pull request Mar 1, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Splitting the introduction sentence in two paragraphs so it's
clearer the list of variables only apply to the second sentence.

PR-URL: #51742
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
richardlau mentioned this pull request Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL