build: disable compiler warning when compiling cares using GN - #51756
Closed
victorgomes wants to merge 1 commit into
Closed
build: disable compiler warning when compiling cares using GN#51756victorgomes wants to merge 1 commit into
victorgomes wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
juanarbol
reviewed
Feb 14, 2024
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Hi! Could you please change the scope to build instead of deps? change the commit title extension so CI is happy?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
See commit guidelines https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
This is fixed in #51687. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
Thanks! I've missed that... I'll close this PR then. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling Node with V8 CI using GN, we get an error due to unused value in cares.