src: implement v8 array iteration using the new callback-based API - #51758
Closed
joyeecheung wants to merge 3 commits into
Closed
src: implement v8 array iteration using the new callback-based API#51758joyeecheung wants to merge 3 commits into
joyeecheung wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Using this to iterate over an array can be faster than calling Array::Get repeatedly. Local experiment shows that this is faster once the array size is bigger than 2.
targos
reviewed
Feb 14, 2024
Comment thread
src/util.h
Outdated
anonrig
approved these changes
Feb 16, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
legendecas
reviewed
Feb 20, 2024
Comment thread
src/util-inl.h
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
legendecas
approved these changes
Feb 22, 2024
Comment thread
src/util-inl.h
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
joyeecheung
added a commit
that referenced
this pull request
Feb 22, 2024
Using this to iterate over an array can be faster than calling Array::Get repeatedly. Local experiment shows that this is faster once the array size is bigger than 2. PR-URL: #51758 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
joyeecheung
added a commit
that referenced
this pull request
Feb 22, 2024
PR-URL: #51758 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Copy link
Copy Markdown
Member
|
@joyeecheung can you backport on 21 please, it seems to fail compilation https://github.com/nodejs/node/actions/runs/8049258088/job/21982250897 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
This can't be backported as it relies on V8 API that doesn't exist on v21.x |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src: implement v8 array iteration using the new callback-based API
Using this to iterate over an array can be faster than calling
Array::Get repeatedly. Local experiment shows that this is faster
once the array size is bigger than 2.
src: use callback-based array iteration in Blob