FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update ngtcp2 to 1.3.0 by nodejs-github-bot · Pull Request #51796 · nodejs/node · GitHub

/ node Public

deps: update ngtcp2 to 1.3.0 - #51796

Merged
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-ngtcp2
Feb 26, 2024
ConversationCommits (1)ChecksFiles changed
Merged

deps: update ngtcp2 to 1.3.0#51796
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-ngtcp2

Conversation

nodejs-github-bot commented Feb 18, 2024

Copy link
Copy Markdown
Collaborator

This is an automated update of ngtcp2 to 1.3.0.

nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Feb 18, 2024

nodejs-github-bot commented Feb 18, 2024

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/security-wg

nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Feb 18, 2024
lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2024

nodejs-github-bot commented Feb 18, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/57172/

nodejs-github-bot commented Feb 22, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/57301/

nodejs-github-bot commented Feb 25, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/57413/

nodejs-github-bot commented Feb 26, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/57426/

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 26, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 26, 2024
nodejs-github-bot merged commit 0350609 into main Feb 26, 2024
nodejs-github-bot deleted the actions/tools-update-ngtcp2 branch February 26, 2024 13:03

nodejs-github-bot commented Feb 26, 2024

Copy link
Copy Markdown
Collaborator Author

Landed in 0350609

marco-ippolito pushed a commit that referenced this pull request Feb 26, 2024
deps: update ngtcp2 to 1.3.0
326a1df 
PR-URL: #51796
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
marco-ippolito pushed a commit that referenced this pull request Feb 27, 2024
deps: update ngtcp2 to 1.3.0
3b29dff 
PR-URL: #51796
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request May 10, 2024
deps: update ngtcp2 to 1.3.0
78f84eb 
PR-URL: #51796
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
richardlau mentioned this pull request May 16, 2024
Merged

marco-ippolito commented May 23, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

it doesnt land cleanly on v20.x, I tried to fix conflict but it fails during build, so I'll request backport

targos commented May 23, 2024

Copy link
Copy Markdown
Member

I wonder what explains the presence of a conflict here.

marco-ippolito commented May 23, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

I wonder what explains the presence of a conflict here.

The only reason could be security release? the version on v20.x-staging is 1.1.0, I haven't investigated though

targos commented May 23, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

The missing PRs before this one are:

They're both labeled dont-land-on-v20.x

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
RafaelGSS RafaelGSS approved these changes
marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL