doc: add mention to GPG_TTY - #51806
Merged
nodejs-github-bot merged 3 commits intoFeb 21, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
BethGriggs
approved these changes
Feb 19, 2024
marco-ippolito
approved these changes
Feb 19, 2024
Comment thread
doc/contributing/releases.md
Outdated
ruyadorno
approved these changes
Feb 19, 2024
Co-authored-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
UlisesGascon
approved these changes
Feb 19, 2024
UlisesGascon
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
lpinca
approved these changes
Feb 19, 2024
RafaelGSS
commented
Feb 19, 2024
Comment thread
doc/contributing/releases.md
Outdated
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/51806 ✔ Done loading data for nodejs/node/pull/51806 ----------------------------------- PR info ------------------------------------ Title doc: add mention to GPG_TTY (#51806) Author Rafael Gonzaga (@RafaelGSS) Branch RafaelGSS:update-release-doc -> nodejs:main Labels doc, author ready Commits 3 - doc: add mention to GPG_TTY - fixup! doc: add mention to GPG_TTY - fixup! fixup! doc: add mention to GPG_TTY Committers 2 - RafaelGSS - GitHub PR-URL: https://github.com/nodejs/node/pull/51806 Reviewed-By: Beth Griggs Reviewed-By: Marco Ippolito Reviewed-By: Ruy Adorno Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51806 Reviewed-By: Beth Griggs Reviewed-By: Marco Ippolito Reviewed-By: Ruy Adorno Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - fixup! fixup! doc: add mention to GPG_TTY ℹ This PR was created on Mon, 19 Feb 2024 14:09:25 GMT ✔ Approvals: 4 ✔ - Beth Griggs (@BethGriggs): https://github.com/nodejs/node/pull/51806#pullrequestreview-1888663213 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/51806#pullrequestreview-1888730986 ✔ - Ruy Adorno (@ruyadorno) (TSC): https://github.com/nodejs/node/pull/51806#pullrequestreview-1888891575 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51806#pullrequestreview-1889055440 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/7990506794 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Needs additional approval after my amend |
Sorry, something went wrong.
UlisesGascon
approved these changes
Feb 21, 2024
marco-ippolito
approved these changes
Feb 21, 2024
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 26, 2024
PR-URL: #51806 Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 27, 2024
PR-URL: #51806 Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51806 Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @nodejs/releasers