src: fix --disable-single-executable-application - #51808
Closed
joyeecheung wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Previously it would not compile if the build is configured with --disable-single-executable-application because we use directives to exclude the definition of SEA-related code completely. This patch changes them so that the SEA code are still compiled and internals can still check whether the executable is an SEA. The executable would not try to load the SEA blob at all if SEA is disabled. If future modifications to the C++ code attempt to load the SEA blob when SEA is disabled, UNREACHABLE() would be raised. If user attempt to generate the SEA blob with --experimental-sea-config with an executable that disables SEA, they would get an error.
joyeecheung
force-pushed
the
fix-disable-sea
branch
from
f60d6d3 to
7b07c8f
Compare
February 19, 2024 18:31
lpinca
reviewed
Feb 20, 2024
lpinca
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
RSLGTM
Sorry, something went wrong.
tniessen
approved these changes
Feb 20, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
tony-go
approved these changes
Feb 21, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/51808 ✔ Done loading data for nodejs/node/pull/51808 ----------------------------------- PR info ------------------------------------ Title src: fix --disable-single-executable-application (#51808) Author Joyee Cheung (@joyeecheung) Branch joyeecheung:fix-disable-sea -> nodejs:main Labels c++, needs-ci, single-executable Commits 1 - src: fix --disable-single-executable-application Committers 1 - Joyee Cheung PR-URL: https://github.com/nodejs/node/pull/51808 Fixes: https://github.com/nodejs/node/issues/51730 Reviewed-By: Tobias Nießen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51808 Fixes: https://github.com/nodejs/node/issues/51730 Reviewed-By: Tobias Nießen -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 19 Feb 2024 18:28:53 GMT ✔ Approvals: 1 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/51808#pullrequestreview-1891732647 ✘ This PR needs to wait 16 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-02-25T23:57:03Z: https://ci.nodejs.org/job/node-test-pull-request/57415/ - Querying data for job/node-test-pull-request/57415/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8042448915 |
Sorry, something went wrong.
aymen94
approved these changes
Feb 26, 2024
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/51808 ✔ Done loading data for nodejs/node/pull/51808 ----------------------------------- PR info ------------------------------------ Title src: fix --disable-single-executable-application (#51808) Author Joyee Cheung (@joyeecheung) Branch joyeecheung:fix-disable-sea -> nodejs:main Labels c++, needs-ci, single-executable Commits 1 - src: fix --disable-single-executable-application Committers 1 - Joyee Cheung PR-URL: https://github.com/nodejs/node/pull/51808 Fixes: https://github.com/nodejs/node/issues/51730 Reviewed-By: Tobias Nießen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51808 Fixes: https://github.com/nodejs/node/issues/51730 Reviewed-By: Tobias Nießen -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 19 Feb 2024 18:28:53 GMT ✔ Approvals: 1 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/51808#pullrequestreview-1891732647 ✘ This PR needs to wait 5 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-02-26T01:41:38Z: https://ci.nodejs.org/job/node-test-pull-request/57415/ - Querying data for job/node-test-pull-request/57415/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8049457418 |
Sorry, something went wrong.
joyeecheung
force-pushed
the
fix-disable-sea
branch
from
f4171ed to
7b07c8f
Compare
February 27, 2024 15:57
Copy link
Copy Markdown
Member
Author
|
Somehow I added a commit from #51887 - removed. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
joyeecheung
added a commit
that referenced
this pull request
Mar 1, 2024
Previously it would not compile if the build is configured with --disable-single-executable-application because we use directives to exclude the definition of SEA-related code completely. This patch changes them so that the SEA code are still compiled and internals can still check whether the executable is an SEA. The executable would not try to load the SEA blob at all if SEA is disabled. If future modifications to the C++ code attempt to load the SEA blob when SEA is disabled, UNREACHABLE() would be raised. If user attempt to generate the SEA blob with --experimental-sea-config with an executable that disables SEA, they would get an error. PR-URL: #51808 Fixes: #51730 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Mar 7, 2024
Previously it would not compile if the build is configured with --disable-single-executable-application because we use directives to exclude the definition of SEA-related code completely. This patch changes them so that the SEA code are still compiled and internals can still check whether the executable is an SEA. The executable would not try to load the SEA blob at all if SEA is disabled. If future modifications to the C++ code attempt to load the SEA blob when SEA is disabled, UNREACHABLE() would be raised. If user attempt to generate the SEA blob with --experimental-sea-config with an executable that disables SEA, they would get an error. PR-URL: #51808 Fixes: #51730 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Previously it would not compile if the build is configured with --disable-single-executable-application because we use directives to exclude the definition of SEA-related code completely. This patch changes them so that the SEA code are still compiled and internals can still check whether the executable is an SEA. The executable would not try to load the SEA blob at all if SEA is disabled. If future modifications to the C++ code attempt to load the SEA blob when SEA is disabled, UNREACHABLE() would be raised. If user attempt to generate the SEA blob with --experimental-sea-config with an executable that disables SEA, they would get an error. PR-URL: #51808 Fixes: #51730 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it would not compile if the build is configured with
--disable-single-executable-application because we use directives
to exclude the definition of SEA-related code completely. This patch
changes them so that the SEA code are still compiled and internals
can still check whether the executable is an SEA. The executable would
not try to load the SEA blob at all if SEA is disabled. If future
modifications to the C++ code attempt to load the SEA blob when SEA
is disabled, UNREACHABLE() would be raised. If user attempt to
generate the SEA blob with --experimental-sea-config with an executable
that disables SEA, they would get an error.
Fixes: #51730