FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test_runner: add ref methods to mocked timers by marco-ippolito · Pull Request #51809 · nodejs/node · GitHub

/ node Public

test_runner: add ref methods to mocked timers - #51809

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:feat/test-runner-mocks
Feb 26, 2024
ConversationCommits (1)ChecksFiles changed
Merged

test_runner: add ref methods to mocked timers#51809
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:feat/test-runner-mocks

Conversation

marco-ippolito commented Feb 19, 2024

Copy link
Copy Markdown
Member

Fixes: #51701
It adds properties ref, unref, refresh, hasRef to mock timers for compatibility.

nodejs-github-bot commented Feb 19, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Feb 19, 2024
marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2024

nodejs-github-bot commented Feb 20, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57197/

nodejs-github-bot commented Feb 20, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57204/

MoLow added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 20, 2024

nodejs-github-bot commented Feb 20, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57206/

nodejs-github-bot commented Feb 20, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57217/

nodejs-github-bot commented Feb 21, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57242/

nodejs-github-bot commented Feb 21, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57247/

nodejs-github-bot commented Feb 21, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57248/

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2024

nodejs-github-bot commented Feb 21, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57251/

rluvaton reviewed Feb 21, 2024
View reviewed changes
Comment thread test/parallel/test-runner-mock-timers.js Outdated

rluvaton Feb 21, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What about adding tests that go over all properties so we won't have that problem again?

marco-ippolito Feb 21, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Do you meanb internal mock properties that are not part of the original Timeout object?

nodejs-github-bot commented Feb 22, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57307/

nodejs-github-bot commented Feb 22, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57308/

nodejs-github-bot commented Feb 23, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57335/

nodejs-github-bot commented Feb 23, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57343/

nodejs-github-bot commented Feb 23, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57347/

nodejs-github-bot commented Feb 23, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57364/

nodejs-github-bot commented Feb 25, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57400/

MoLow commented Feb 25, 2024

Copy link
Copy Markdown
Member

please rebase to include #51834

MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2024

nodejs-github-bot commented Feb 26, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57429/

nodejs-github-bot commented Feb 26, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57436/

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 26, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 26, 2024
nodejs-github-bot merged commit 6cb8a60 into nodejs:main Feb 26, 2024

nodejs-github-bot commented Feb 26, 2024

Copy link
Copy Markdown
Collaborator

Landed in 6cb8a60

marco-ippolito added a commit that referenced this pull request Feb 27, 2024
test_runner: add ref methods to mocked timers
5f94912 
Fixes: #51701
PR-URL: #51809
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tierney Cyren <hello@bnb.im>
marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
test_runner: add ref methods to mocked timers
cea90dc 
Fixes: #51701
PR-URL: #51809
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tierney Cyren <hello@bnb.im>
richardlau mentioned this pull request Mar 25, 2024
Merged
cjihrig mentioned this pull request Apr 2, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rluvaton rluvaton left review comments
bnb bnb approved these changes
MoLow MoLow approved these changes
atlowChemi atlowChemi approved these changes
+1 more reviewer
mertcanaltin mertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MockTimers does not mock Timer properties

7 participants

Back | FazBrowse Home | New Git URL