net: fix connect crash when call destroy in lookup handler - #51826
Merged
nodejs-github-bot merged 1 commit intoFeb 27, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
theanarkh
force-pushed
the
fix_connect_crash_when_call_destroy_in_lookup_handler
branch
from
6a7c817 to
18718f4
Compare
February 21, 2024 18:11
ShogunPanda
approved these changes
Feb 22, 2024
ShogunPanda
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Feb 22, 2024
Comment thread
test/parallel/test-destroy-socket-in-lookup.js
Outdated
Comment thread
test/parallel/test-destroy-socket-in-lookup.js
Outdated
mcollina
approved these changes
Feb 23, 2024
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
theanarkh
force-pushed
the
fix_connect_crash_when_call_destroy_in_lookup_handler
branch
from
18718f4 to
23b04ca
Compare
February 23, 2024 10:14
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/51826 ✔ Done loading data for nodejs/node/pull/51826 ----------------------------------- PR info ------------------------------------ Title net: fix connect crash when call destroy in lookup handler (#51826) Author theanarkh (@theanarkh) Branch theanarkh:fix_connect_crash_when_call_destroy_in_lookup_handler -> nodejs:main Labels net, author ready, needs-ci Commits 1 - net: fix connect crash when call destroy in lookup handler Committers 1 - theanarkh PR-URL: https://github.com/nodejs/node/pull/51826 Fixes: https://github.com/nodejs/node/issues/50841 Reviewed-By: Paolo Insogna Reviewed-By: Luigi Pinca Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51826 Fixes: https://github.com/nodejs/node/issues/50841 Reviewed-By: Paolo Insogna Reviewed-By: Luigi Pinca Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - net: fix connect crash when call destroy in lookup handler ℹ This PR was created on Wed, 21 Feb 2024 17:12:43 GMT ✔ Approvals: 3 ✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/51826#pullrequestreview-1895223170 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51826#pullrequestreview-1896819310 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/51826#pullrequestreview-1897763462 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-02-23T10:16:28Z: https://ci.nodejs.org/job/node-test-pull-request/57340/ - Querying data for job/node-test-pull-request/57340/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8028025584 |
Sorry, something went wrong.
gengjiawen
approved these changes
Feb 27, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #50841
cc @ShogunPanda