FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: split wasi tests by joyeecheung · Pull Request #51836 · nodejs/node · GitHub

/ node Public

test: split wasi tests - #51836

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:wasi-split
Feb 24, 2024
ConversationCommits (1)ChecksFiles changed
Merged

test: split wasi tests#51836
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:wasi-split

Conversation

joyeecheung commented Feb 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Move the child process code into a fixture and split the test
so that it can be run in parallel and it's easier to identify
where the failure is coming from. Also use the
spawnSyncAndExitWithoutError() utility so that the test shows
complete information on failure.

Instead of marking all the wasi tests as flaky, only mark the
wasi-poll one which is flaking in the CI now.

Refs: #51822

nodejs-github-bot commented Feb 22, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/wasi

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2024
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 22, 2024

joyeecheung commented Feb 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

When #51834 lands we need to update the status file to only mark the affected test case as flaky (I suspect it's wasi-poll).

Before the split the wasi tests on my laptop finish in 10s, after it finish in 6s (and it's also the wasi-poll test taking all that 6s while others already finish in ~3s).

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2024

nodejs-github-bot commented Feb 22, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57299/

joyeecheung commented Feb 22, 2024

Copy link
Copy Markdown
Member Author

The CI shows that test-wasi-poll is indeed what triggers the flake: https://ci.nodejs.org/job/node-test-binary-windows-js-suites/25993/

Rebased and updated the status file to only mark test-wasi-poll as flaky.

joyeecheung mentioned this pull request Feb 22, 2024
Closed
test: split wasi tests
a8b6574 
Move the child process code into a fixture and split the test
so that it can be run in parallel and it's easier to identify
where the failure is coming from. Also use the
spawnSyncAndExitWithoutError() utility so that the test shows
complete information on failure.

Instead of marking all the wasi tests as flaky, only mark the
wasi-poll one which is flaking in the CI now.
joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2024

nodejs-github-bot commented Feb 22, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57315/

joyeecheung commented Feb 23, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

CI seemed happy with the wasi tests (Windows still failed due to an rm error)

nodejs-github-bot commented Feb 23, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57324/

nodejs-github-bot commented Feb 23, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57350/

joyeecheung commented Feb 23, 2024

Copy link
Copy Markdown
Member Author

Stress tests on Windows for the unmarked tests: https://ci.nodejs.org/view/Stress/job/node-stress-single-test/474/

nodejs-github-bot commented Feb 23, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57354/

joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 23, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2024
nodejs-github-bot merged commit a5376c5 into nodejs:main Feb 24, 2024

nodejs-github-bot commented Feb 24, 2024

Copy link
Copy Markdown
Collaborator

Landed in a5376c5

marco-ippolito pushed a commit that referenced this pull request Feb 26, 2024
test: split wasi tests
880e486 
Move the child process code into a fixture and split the test
so that it can be run in parallel and it's easier to identify
where the failure is coming from. Also use the
spawnSyncAndExitWithoutError() utility so that the test shows
complete information on failure.

Instead of marking all the wasi tests as flaky, only mark the
wasi-poll one which is flaking in the CI now.

PR-URL: #51836
Refs: #51822
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
marco-ippolito pushed a commit that referenced this pull request Feb 27, 2024
test: split wasi tests
f845a16 
Move the child process code into a fixture and split the test
so that it can be run in parallel and it's easier to identify
where the failure is coming from. Also use the
spawnSyncAndExitWithoutError() utility so that the test shows
complete information on failure.

Instead of marking all the wasi tests as flaky, only mark the
wasi-poll one which is flaking in the CI now.

PR-URL: #51836
Refs: #51822
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
test: split wasi tests
dd708d3 
Move the child process code into a fixture and split the test
so that it can be run in parallel and it's easier to identify
where the failure is coming from. Also use the
spawnSyncAndExitWithoutError() utility so that the test shows
complete information on failure.

Instead of marking all the wasi tests as flaky, only mark the
wasi-poll one which is flaking in the CI now.

PR-URL: #51836
Refs: #51822
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau mentioned this pull request Mar 25, 2024
Merged
joyeecheung mentioned this pull request Feb 13, 2025
Merged
joyeecheung mentioned this pull request Sep 2, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
marco-ippolito marco-ippolito approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL