tools: fix missing [[fallthrough]] in js2c - #51845
Merged
nodejs-github-bot merged 1 commit intoFeb 25, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
The latest clang warns about this.
zcbenz
force-pushed
the
fix-fallthrough
branch
from
d8a0e07 to
88322f0
Compare
February 23, 2024 08:14
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
legendecas
approved these changes
Feb 23, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
approved these changes
Feb 23, 2024
mertcanaltin
approved these changes
Feb 23, 2024
VoltrexKeyva
approved these changes
Feb 23, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
joyeecheung
approved these changes
Feb 23, 2024
lpinca
approved these changes
Feb 24, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 26, 2024
The latest clang warns about this. PR-URL: #51845 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 27, 2024
The latest clang warns about this. PR-URL: #51845 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
The latest clang warns about this. PR-URL: #51845 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest clang warns about this.