FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

util: add styleText API to text formatting by RafaelGSS · Pull Request #51850 · nodejs/node · GitHub

/ node Public

util: add styleText API to text formatting - #51850

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RafaelGSS:add-util-text-color
Feb 26, 2024
ConversationCommits (1)ChecksFiles changed
Merged

util: add styleText API to text formatting#51850
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RafaelGSS:add-util-text-color

Conversation

RafaelGSS commented Feb 23, 2024

Copy link
Copy Markdown
Member

A fresh new PR from #43371.

@hemanth I took the liberty to create a new fresh PR (including a few changes) as your PR is almost 2 years old. I have included you as Co-Author I hope you don't mind (I tried to search for your handle in the OpenJS Foundation Slack, but I couldn't find it).

The concerns raised in the original blocker can be discussed again if necessary, but I believe we should have this API on Node.js.

cc: @nodejs/tsc

RafaelGSS added the semver-minor PRs that contain new features and should be released in the next minor version. label Feb 23, 2024
nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Feb 23, 2024
mcollina approved these changes Feb 23, 2024
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2024

nodejs-github-bot commented Feb 23, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57348/

edsadr approved these changes Feb 23, 2024
View reviewed changes

edsadr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Really happy to see this happening 🎉

aduh95 approved these changes Feb 23, 2024
View reviewed changes
Comment thread lib/util.js Outdated
Comment thread test/parallel/test-util-formattext.js Outdated
Comment thread test/parallel/test-util-formattext.js Outdated
Comment thread doc/api/util.md Outdated
Comment thread doc/api/util.md Outdated
meyfa reviewed Feb 23, 2024
View reviewed changes
Comment thread doc/api/util.md Outdated
GeoffreyBooth reviewed Feb 23, 2024
View reviewed changes
Comment thread doc/api/util.md Outdated
Comment thread doc/api/util.md Outdated
RafaelGSS changed the title util: add formatText API to text formatting util: add styleText API to text formatting Feb 23, 2024
RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2024

nodejs-github-bot commented Feb 23, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57356/

aduh95 approved these changes Feb 23, 2024
View reviewed changes

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Consider pushing an amend commit to update the commit message (git commit --allow-empty -m 'amend! util: add formatText API to text formatting' -m 'util: add `styleText` API for text formatting' -m 'Co-Authored-By: Hemanth HM <hemanth.hm@gmail.com>').

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2024

nodejs-github-bot commented Feb 23, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57360/

GeoffreyBooth reviewed Feb 23, 2024
View reviewed changes
Comment thread doc/api/util.md Outdated
Comment thread doc/api/util.md Outdated
Comment thread lib/util.js Outdated

hemanth commented Feb 24, 2024

Copy link
Copy Markdown
Contributor

Thanks a lot for taking the initiative to restart this effort, RafaelGSS! ❤️

MoLow reviewed Feb 25, 2024
View reviewed changes
Comment thread doc/api/util.md Outdated
util: add styleText API to text formatting
24faff7 
Co-Authored-By: Hemanth HM <hemanth.hm@gmail.com>
RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 25, 2024
marco-ippolito added a commit that referenced this pull request Mar 1, 2024
2024-03-06, Version 21.7.0 (Current)
4533c19 
Notable changes:

build:
  * (SEMVER-MINOR) build opt to set local location of headers (Michael Dawson) #51525
crypto:
  * (SEMVER-MINOR) implement crypto.hash() (Joyee Cheung) #51044
  * update root certificates to NSS 3.98 (Node.js GitHub Bot) #51794
doc:
  * add zcbenz to collaborators (Cheng Zhao) #51812
  * add lemire to collaborators (Daniel Lemire) #51572
http2:
  * (SEMVER-MINOR) add h2 compat support for appendHeader (Tim Perry) #51412
  * (SEMVER-MINOR) add server handshake utility (snek) #51172
  * (SEMVER-MINOR) receive customsettings (Marten Richter) #51323
lib:
  * (SEMVER-MINOR) move encodingsMap to internal/util (Joyee Cheung) #51044
sea:
  * (SEMVER-MINOR) support sea.getRawAsset() (Joyee Cheung) #50960
  * (SEMVER-MINOR) support embedding assets (Joyee Cheung) #50960
src:
  * (SEMVER-MINOR) print string content better in BlobDeserializer (Joyee Cheung) #50960
  * (SEMVER-MINOR) support multi-line values for .env file (IlyasShabi) #51289
  * (SEMVER-MINOR) add `process.loadEnvFile` and `util.parseEnv` (Yagiz Nizipli) #51476
  * (SEMVER-MINOR) do not coerce dotenv paths (Tobias Nießen) #51425
stream:
  * (SEMVER-MINOR) implement `min` option for `ReadableStreamBYOBReader.read` (Mattias Buelens) #50888
util:
  * (SEMVER-MINOR) add styleText API to text formatting (Rafael Gonzaga) #51850
vm:
  * (SEMVER-MINOR) support using the default loader to handle dynamic import() (Joyee Cheung) #51244

PR-URL: #51932
marco-ippolito added a commit that referenced this pull request Mar 2, 2024
2024-03-06, Version 21.7.0 (Current)
bcd4f1a 
Notable changes:

build:
  * (SEMVER-MINOR) build opt to set local location of headers (Michael Dawson) #51525
crypto:
  * (SEMVER-MINOR) implement crypto.hash() (Joyee Cheung) #51044
  * update root certificates to NSS 3.98 (Node.js GitHub Bot) #51794
doc:
  * add zcbenz to collaborators (Cheng Zhao) #51812
  * add lemire to collaborators (Daniel Lemire) #51572
http2:
  * (SEMVER-MINOR) add h2 compat support for appendHeader (Tim Perry) #51412
  * (SEMVER-MINOR) add server handshake utility (snek) #51172
  * (SEMVER-MINOR) receive customsettings (Marten Richter) #51323
lib:
  * (SEMVER-MINOR) move encodingsMap to internal/util (Joyee Cheung) #51044
sea:
  * (SEMVER-MINOR) support sea.getRawAsset() (Joyee Cheung) #50960
  * (SEMVER-MINOR) support embedding assets (Joyee Cheung) #50960
src:
  * (SEMVER-MINOR) print string content better in BlobDeserializer (Joyee Cheung) #50960
  * (SEMVER-MINOR) support multi-line values for .env file (IlyasShabi) #51289
  * (SEMVER-MINOR) add `process.loadEnvFile` and `util.parseEnv` (Yagiz Nizipli) #51476
  * (SEMVER-MINOR) do not coerce dotenv paths (Tobias Nießen) #51425
stream:
  * (SEMVER-MINOR) implement `min` option for `ReadableStreamBYOBReader.read` (Mattias Buelens) #50888
util:
  * (SEMVER-MINOR) add styleText API to text formatting (Rafael Gonzaga) #51850
vm:
  * (SEMVER-MINOR) support using the default loader to handle dynamic import() (Joyee Cheung) #51244

PR-URL: #51932
marco-ippolito added a commit that referenced this pull request Mar 5, 2024
2024-03-06, Version 21.7.0 (Current)
bd81180 
Notable changes:

build:
  * (SEMVER-MINOR) build opt to set local location of headers (Michael Dawson) #51525
crypto:
  * (SEMVER-MINOR) implement crypto.hash() (Joyee Cheung) #51044
  * update root certificates to NSS 3.98 (Node.js GitHub Bot) #51794
doc:
  * add zcbenz to collaborators (Cheng Zhao) #51812
  * add lemire to collaborators (Daniel Lemire) #51572
http2:
  * (SEMVER-MINOR) add h2 compat support for appendHeader (Tim Perry) #51412
  * (SEMVER-MINOR) add server handshake utility (snek) #51172
  * (SEMVER-MINOR) receive customsettings (Marten Richter) #51323
lib:
  * (SEMVER-MINOR) move encodingsMap to internal/util (Joyee Cheung) #51044
sea:
  * (SEMVER-MINOR) support sea.getRawAsset() (Joyee Cheung) #50960
  * (SEMVER-MINOR) support embedding assets (Joyee Cheung) #50960
src:
  * (SEMVER-MINOR) print string content better in BlobDeserializer (Joyee Cheung) #50960
  * (SEMVER-MINOR) support multi-line values for .env file (IlyasShabi) #51289
  * (SEMVER-MINOR) add `process.loadEnvFile` and `util.parseEnv` (Yagiz Nizipli) #51476
  * (SEMVER-MINOR) do not coerce dotenv paths (Tobias Nießen) #51425
stream:
  * (SEMVER-MINOR) implement `min` option for `ReadableStreamBYOBReader.read` (Mattias Buelens) #50888
util:
  * (SEMVER-MINOR) add styleText API to text formatting (Rafael Gonzaga) #51850
vm:
  * (SEMVER-MINOR) support using the default loader to handle dynamic import() (Joyee Cheung) #51244

PR-URL: #51932
marco-ippolito added a commit that referenced this pull request Mar 5, 2024
2024-03-06, Version 21.7.0 (Current)
47e6820 
Notable changes:

build:
  * (SEMVER-MINOR) build opt to set local location of headers (Michael Dawson) #51525
crypto:
  * (SEMVER-MINOR) implement crypto.hash() (Joyee Cheung) #51044
  * update root certificates to NSS 3.98 (Node.js GitHub Bot) #51794
doc:
  * add zcbenz to collaborators (Cheng Zhao) #51812
  * add lemire to collaborators (Daniel Lemire) #51572
http2:
  * (SEMVER-MINOR) add h2 compat support for appendHeader (Tim Perry) #51412
  * (SEMVER-MINOR) add server handshake utility (snek) #51172
  * (SEMVER-MINOR) receive customsettings (Marten Richter) #51323
lib:
  * (SEMVER-MINOR) move encodingsMap to internal/util (Joyee Cheung) #51044
sea:
  * (SEMVER-MINOR) support sea.getRawAsset() (Joyee Cheung) #50960
  * (SEMVER-MINOR) support embedding assets (Joyee Cheung) #50960
src:
  * (SEMVER-MINOR) print string content better in BlobDeserializer (Joyee Cheung) #50960
  * (SEMVER-MINOR) support multi-line values for .env file (IlyasShabi) #51289
  * (SEMVER-MINOR) add `process.loadEnvFile` and `util.parseEnv` (Yagiz Nizipli) #51476
  * (SEMVER-MINOR) do not coerce dotenv paths (Tobias Nießen) #51425
stream:
  * (SEMVER-MINOR) implement `min` option for `ReadableStreamBYOBReader.read` (Mattias Buelens) #50888
util:
  * (SEMVER-MINOR) add styleText API to text formatting (Rafael Gonzaga) #51850
vm:
  * (SEMVER-MINOR) support using the default loader to handle dynamic import() (Joyee Cheung) #51244

PR-URL: #51932
RafaelGSS pushed a commit that referenced this pull request Mar 6, 2024
2024-03-06, Version 21.7.0 (Current)
2246cd9 
Notable changes:

build:
  * (SEMVER-MINOR) build opt to set local location of headers (Michael Dawson) #51525
crypto:
  * (SEMVER-MINOR) implement crypto.hash() (Joyee Cheung) #51044
  * update root certificates to NSS 3.98 (Node.js GitHub Bot) #51794
doc:
  * add zcbenz to collaborators (Cheng Zhao) #51812
  * add lemire to collaborators (Daniel Lemire) #51572
http2:
  * (SEMVER-MINOR) add h2 compat support for appendHeader (Tim Perry) #51412
  * (SEMVER-MINOR) add server handshake utility (snek) #51172
  * (SEMVER-MINOR) receive customsettings (Marten Richter) #51323
lib:
  * (SEMVER-MINOR) move encodingsMap to internal/util (Joyee Cheung) #51044
sea:
  * (SEMVER-MINOR) support sea.getRawAsset() (Joyee Cheung) #50960
  * (SEMVER-MINOR) support embedding assets (Joyee Cheung) #50960
src:
  * (SEMVER-MINOR) print string content better in BlobDeserializer (Joyee Cheung) #50960
  * (SEMVER-MINOR) support multi-line values for .env file (IlyasShabi) #51289
  * (SEMVER-MINOR) add `process.loadEnvFile` and `util.parseEnv` (Yagiz Nizipli) #51476
  * (SEMVER-MINOR) do not coerce dotenv paths (Tobias Nießen) #51425
stream:
  * (SEMVER-MINOR) implement `min` option for `ReadableStreamBYOBReader.read` (Mattias Buelens) #50888
util:
  * (SEMVER-MINOR) add styleText API to text formatting (Rafael Gonzaga) #51850
vm:
  * (SEMVER-MINOR) support using the default loader to handle dynamic import() (Joyee Cheung) #51244

PR-URL: #51932
crowlKats mentioned this pull request Mar 6, 2024
Merged
crowlKats added a commit to denoland/deno that referenced this pull request Mar 6, 2024
feat(node/util): styleText (#22758)
0fb67ce 
Implements nodejs/node#51850
kibertoad reviewed Mar 6, 2024
View reviewed changes
Comment thread lib/util.js
*/
function styleText(format, text) {
validateString(text, 'text');
const formatCodes = inspect.colors[format];

kibertoad Mar 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

does it make sense to do this check on every call? could be done once and cached

nvm, happy path should be pretty fast here, misread the code

CanadaHonk mentioned this pull request Mar 7, 2024
Closed

hemanth commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

I was wondering if there have been any updates on this issue. It appears that #43371 was marked as blocked pending a decision. \cc @mcollina

This was referenced Mar 7, 2024
Closed
Closed

mcollina commented Mar 7, 2024

Copy link
Copy Markdown
Member

I guess this module landing was a decision on that.

bakkot commented Mar 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Seems kind of a shame to have left out support for the common NO_COLOR option environment variable, or for checking isatty and FORCE_COLOR. That means people trying to switch to this from (e.g.) picocolors or chalk or colors.js or ansi-colors or colorette or kleur are (probably unknowingly) going to end up with a worse experience for their users. Node itself supports those as well.

I'm very much in favor of the effort to pull more widely-used features into core, but I feel like the process ought to include a bit more review of what conventions the ecosystem has settled on before doing so.

meyfa commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

This is at stability 1.1 (Active Development), is it not? Wouldn't that mean that such functionality can still be added?

kibertoad commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

It only landed in 21.x so far, so yeah, should be OK to change it

RafaelGSS commented Mar 7, 2024

Copy link
Copy Markdown
Member Author

Folks, please see #51959. Consider opening a new issue to discuss the feature and stability of this new API instead of commenting on this PR.

littledivy pushed a commit to denoland/deno that referenced this pull request Mar 8, 2024
feat(node/util): styleText (#22758)
1a217c9 
Implements nodejs/node#51850
hail2u added a commit to hail2u/hail2u.net that referenced this pull request Mar 12, 2024
Bookmark nodejs/node#51850
c1404ae
richardlau pushed a commit that referenced this pull request Mar 25, 2024
util: add styleText API to text formatting
c501346 
Co-Authored-By: Hemanth HM <hemanth.hm@gmail.com>
PR-URL: #51850
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
richardlau added a commit that referenced this pull request Mar 25, 2024
2024-03-26, Version 20.12.0 'Iron' (LTS)
94fb854 
Notable changes:

build:
  * (SEMVER-MINOR) build opt to set local location of headers (Michael Dawson) #51525
crypto:
  * (SEMVER-MINOR) implement crypto.hash() (Joyee Cheung) #51044
  * update root certificates to NSS 3.98 (Node.js GitHub Bot) #51794
doc:
  * add lemire to collaborators (Daniel Lemire) #51572
  * add zcbenz to collaborators (Cheng Zhao) #51812
lib:
  * (SEMVER-MINOR) move encodingsMap to internal/util (Joyee Cheung) #51044
sea:
  * (SEMVER-MINOR) support sea.getRawAsset() (Joyee Cheung) #50960
  * (SEMVER-MINOR) support embedding assets (Joyee Cheung) #50960
src:
  * (SEMVER-MINOR) print string content better in BlobDeserializer (Joyee Cheung) #50960
util:
  * (SEMVER-MINOR) add styleText API to text formatting (Rafael Gonzaga) #51850
vm:
  * (SEMVER-MINOR) support using the default loader to handle dynamic import() (Joyee Cheung) #51244

PR-URL: #52212
richardlau mentioned this pull request Mar 25, 2024
Merged
richardlau added a commit that referenced this pull request Mar 26, 2024
2024-03-26, Version 20.12.0 'Iron' (LTS)
6d2d3f1 
Notable changes:

build:
  * (SEMVER-MINOR) build opt to set local location of headers (Michael Dawson) #51525
crypto:
  * (SEMVER-MINOR) implement crypto.hash() (Joyee Cheung) #51044
  * update root certificates to NSS 3.98 (Node.js GitHub Bot) #51794
doc:
  * add lemire to collaborators (Daniel Lemire) #51572
  * add zcbenz to collaborators (Cheng Zhao) #51812
lib:
  * (SEMVER-MINOR) move encodingsMap to internal/util (Joyee Cheung) #51044
sea:
  * (SEMVER-MINOR) support sea.getRawAsset() (Joyee Cheung) #50960
  * (SEMVER-MINOR) support embedding assets (Joyee Cheung) #50960
src:
  * (SEMVER-MINOR) print string content better in BlobDeserializer (Joyee Cheung) #50960
util:
  * (SEMVER-MINOR) add styleText API to text formatting (Rafael Gonzaga) #51850
vm:
  * (SEMVER-MINOR) support using the default loader to handle dynamic import() (Joyee Cheung) #51244

PR-URL: #52212
coderabbitai Bot mentioned this pull request Mar 25, 2026
Closed
coderabbitai Bot mentioned this pull request Jul 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 approved these changes
mcollina mcollina approved these changes
GeoffreyBooth GeoffreyBooth approved these changes
MoLow MoLow approved these changes
marco-ippolito marco-ippolito approved these changes
+3 more reviewers
kibertoad kibertoad left review comments
meyfa meyfa left review comments
edsadr edsadr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. semver-minor PRs that contain new features and should be released in the next minor version. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL