FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: update guide link for Event Loop by shrujalshah28 · Pull Request #51874 · nodejs/node · GitHub

/ node Public

doc: update guide link for Event Loop - #51874

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
shrujalshah28:main
Feb 27, 2024
Merged

doc: update guide link for Event Loop#51874
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
shrujalshah28:main

Conversation

Copy link
Copy Markdown
Contributor

Fixes #51872

nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Feb 25, 2024
MoLow added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 26, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @MoLow. Please 👍 to approve.

MoLow commented Feb 26, 2024

Copy link
Copy Markdown
Member

@ovflowd do we have a way to fix this broken link prior to the next version release?

ovflowd commented Feb 26, 2024

Copy link
Copy Markdown
Member

Yea the issue is that the redirect is not working correctly.

Ill make a hotfix in a few on nodejs.org side of things, we shouldn't need to change the link here.

ovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fix is being deployed on Node.js Website. Note that this can still be merged for the sake of being up-to-date; But isn't needed anymore.

ovflowd requested a review from trivikr February 26, 2024 10:10

ovflowd commented Feb 26, 2024

Copy link
Copy Markdown
Member

(Upsie, accidentally clicked on the button of request re-review)

marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 27, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 27, 2024
nodejs-github-bot merged commit 7824a79 into nodejs:main Feb 27, 2024

Copy link
Copy Markdown
Collaborator

Landed in 7824a79

marco-ippolito pushed a commit that referenced this pull request Feb 29, 2024
PR-URL: #51874
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito mentioned this pull request Mar 1, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51874
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
richardlau mentioned this pull request Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. process Issues and PRs related to the process subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

404 hyperlink in nextTick documentation

10 participants


Back | FazBrowse Home | New Git URL