FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix actual result of example is different in events by deokjinkim · Pull Request #51925 · nodejs/node · GitHub

/ node Public

doc: fix actual result of example is different in events - #51925

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
deokjinkim:240301_fix_example_in_events
Mar 2, 2024
Merged

doc: fix actual result of example is different in events#51925
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
deokjinkim:240301_fix_example_in_events

Conversation

deokjinkim commented Feb 29, 2024
edited
Loading

Copy link
Copy Markdown
Contributor

Expected result:

a b MyEmitter {
  _events: [Object: null prototype] { event: [Function (anonymous)] },
  _eventsCount: 1,
  _maxListeners: undefined,
  [Symbol(kCapture)]: false
} true

Actual result:

a b MyEmitter {
  _events: [Object: null prototype] { event: [Function (anonymous)] },
  _eventsCount: 1,
  _maxListeners: undefined,
  [Symbol(shapeMode)]: false, // This line is added
  [Symbol(kCapture)]: false
} true

Refs: #50428

nodejs-github-bot added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Feb 29, 2024
deokjinkim added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 2, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 2, 2024
nodejs-github-bot merged commit 9930f11 into nodejs:main Mar 2, 2024

Copy link
Copy Markdown
Collaborator

Landed in 9930f11

targos pushed a commit that referenced this pull request Mar 7, 2024
Refs: #50428
PR-URL: #51925
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
targos mentioned this pull request Mar 7, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
Refs: #50428
PR-URL: #51925
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
richardlau mentioned this pull request Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL